Chromium Code Reviews| Index: chrome/browser/translate/translate_ranker_metrics_provider.cc |
| diff --git a/chrome/browser/translate/translate_ranker_metrics_provider.cc b/chrome/browser/translate/translate_ranker_metrics_provider.cc |
| index ba98a639a5fa96c621120d1812414fecc52f5f08..4d9b5fb120710e41883ec76b8698eb8a41e82918 100644 |
| --- a/chrome/browser/translate/translate_ranker_metrics_provider.cc |
| +++ b/chrome/browser/translate/translate_ranker_metrics_provider.cc |
| @@ -21,7 +21,7 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics( |
| TranslateRanker* ranker = |
| TranslateRankerFactory::GetForBrowserContext(profile); |
| if (!ranker) |
| - return; |
| + continue; |
|
Roger McFarlane (Chromium)
2017/06/06 19:28:27
doh! good catch!
hamelphi
2017/06/06 20:28:05
Acknowledged.
|
| std::vector<metrics::TranslateEventProto> translate_events; |
| ranker->FlushTranslateEvents(&translate_events); |
| @@ -32,4 +32,24 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics( |
| } |
| } |
| +void TranslateRankerMetricsProvider::SetLoggingState(bool logging_enabled) { |
| + std::vector<Profile*> loaded_profiles = |
| + g_browser_process->profile_manager()->GetLoadedProfiles(); |
| + for (Profile* profile : loaded_profiles) { |
| + TranslateRanker* ranker = |
| + TranslateRankerFactory::GetForBrowserContext(profile); |
| + if (!ranker) |
| + continue; |
| + ranker->EnableLogging(logging_enabled); |
|
Roger McFarlane (Chromium)
2017/06/06 19:28:27
optional:
if (ranker)
ranker->EnableLogging(...
hamelphi
2017/06/06 20:28:05
Done.
|
| + } |
| +} |
| + |
| +void TranslateRankerMetricsProvider::OnRecordingEnabled() { |
| + SetLoggingState(true); |
| +} |
| + |
| +void TranslateRankerMetricsProvider::OnRecordingDisabled() { |
| + SetLoggingState(false); |
| +} |
| + |
| } // namespace translate |