Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2699)

Unified Diff: chrome/browser/translate/translate_ranker_metrics_provider.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Nit. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_ranker_metrics_provider.cc
diff --git a/chrome/browser/translate/translate_ranker_metrics_provider.cc b/chrome/browser/translate/translate_ranker_metrics_provider.cc
index ba98a639a5fa96c621120d1812414fecc52f5f08..4d9b5fb120710e41883ec76b8698eb8a41e82918 100644
--- a/chrome/browser/translate/translate_ranker_metrics_provider.cc
+++ b/chrome/browser/translate/translate_ranker_metrics_provider.cc
@@ -21,7 +21,7 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
TranslateRanker* ranker =
TranslateRankerFactory::GetForBrowserContext(profile);
if (!ranker)
- return;
+ continue;
Roger McFarlane (Chromium) 2017/06/06 19:28:27 doh! good catch!
hamelphi 2017/06/06 20:28:05 Acknowledged.
std::vector<metrics::TranslateEventProto> translate_events;
ranker->FlushTranslateEvents(&translate_events);
@@ -32,4 +32,24 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
}
}
+void TranslateRankerMetricsProvider::SetLoggingState(bool logging_enabled) {
+ std::vector<Profile*> loaded_profiles =
+ g_browser_process->profile_manager()->GetLoadedProfiles();
+ for (Profile* profile : loaded_profiles) {
+ TranslateRanker* ranker =
+ TranslateRankerFactory::GetForBrowserContext(profile);
+ if (!ranker)
+ continue;
+ ranker->EnableLogging(logging_enabled);
Roger McFarlane (Chromium) 2017/06/06 19:28:27 optional: if (ranker) ranker->EnableLogging(...
hamelphi 2017/06/06 20:28:05 Done.
+ }
+}
+
+void TranslateRankerMetricsProvider::OnRecordingEnabled() {
+ SetLoggingState(true);
+}
+
+void TranslateRankerMetricsProvider::OnRecordingDisabled() {
+ SetLoggingState(false);
+}
+
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698