Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2863)

Unified Diff: chrome/browser/translate/translate_ranker_metrics_provider.h

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Nit. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_ranker_metrics_provider.h
diff --git a/chrome/browser/translate/translate_ranker_metrics_provider.h b/chrome/browser/translate/translate_ranker_metrics_provider.h
index 7490cab99dcf4c6d12f4b88e6c82580aaceead3a..2dcca90b4413cc0531cfe0a7aaeee3e6e0f324a8 100644
--- a/chrome/browser/translate/translate_ranker_metrics_provider.h
+++ b/chrome/browser/translate/translate_ranker_metrics_provider.h
@@ -14,12 +14,17 @@ class TranslateRankerMetricsProvider : public metrics::MetricsProvider {
public:
TranslateRankerMetricsProvider() {}
~TranslateRankerMetricsProvider() override {}
+ void OnRecordingEnabled() override;
Roger McFarlane (Chromium) 2017/06/06 19:28:27 Should these be down next to ProvideGeneralMetrics
hamelphi 2017/06/06 20:28:06 Actually, I don't think ProvideGeneralMetrics shou
+ void OnRecordingDisabled() override;
private:
// From metrics::MetricsProvider...
void ProvideGeneralMetrics(
metrics::ChromeUserMetricsExtension* uma_proto) override;
+ // Enables or disables the logging for translate ranker.
+ void SetLoggingState(bool logging_enabled);
+
DISALLOW_COPY_AND_ASSIGN(TranslateRankerMetricsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698