Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: chrome/browser/translate/translate_ranker_metrics_provider.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Nit. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_ranker_metrics_provider.h" 5 #include "chrome/browser/translate/translate_ranker_metrics_provider.h"
6 6
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/profiles/profile_manager.h" 8 #include "chrome/browser/profiles/profile_manager.h"
9 #include "chrome/browser/translate/translate_ranker_factory.h" 9 #include "chrome/browser/translate/translate_ranker_factory.h"
10 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h" 10 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
11 #include "components/metrics/proto/translate_event.pb.h" 11 #include "components/metrics/proto/translate_event.pb.h"
12 #include "components/translate/core/browser/translate_ranker.h" 12 #include "components/translate/core/browser/translate_ranker.h"
13 13
14 namespace translate { 14 namespace translate {
15 15
16 void TranslateRankerMetricsProvider::ProvideGeneralMetrics( 16 void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
17 metrics::ChromeUserMetricsExtension* uma_proto) { 17 metrics::ChromeUserMetricsExtension* uma_proto) {
18 std::vector<Profile*> loaded_profiles = 18 std::vector<Profile*> loaded_profiles =
19 g_browser_process->profile_manager()->GetLoadedProfiles(); 19 g_browser_process->profile_manager()->GetLoadedProfiles();
20 for (Profile* profile : loaded_profiles) { 20 for (Profile* profile : loaded_profiles) {
21 TranslateRanker* ranker = 21 TranslateRanker* ranker =
22 TranslateRankerFactory::GetForBrowserContext(profile); 22 TranslateRankerFactory::GetForBrowserContext(profile);
23 if (!ranker) 23 if (!ranker)
24 return; 24 continue;
Roger McFarlane (Chromium) 2017/06/06 19:28:27 doh! good catch!
hamelphi 2017/06/06 20:28:05 Acknowledged.
25 25
26 std::vector<metrics::TranslateEventProto> translate_events; 26 std::vector<metrics::TranslateEventProto> translate_events;
27 ranker->FlushTranslateEvents(&translate_events); 27 ranker->FlushTranslateEvents(&translate_events);
28 28
29 for (auto& event : translate_events) { 29 for (auto& event : translate_events) {
30 uma_proto->add_translate_event()->Swap(&event); 30 uma_proto->add_translate_event()->Swap(&event);
31 } 31 }
32 } 32 }
33 } 33 }
34 34
35 void TranslateRankerMetricsProvider::SetLoggingState(bool logging_enabled) {
36 std::vector<Profile*> loaded_profiles =
37 g_browser_process->profile_manager()->GetLoadedProfiles();
38 for (Profile* profile : loaded_profiles) {
39 TranslateRanker* ranker =
40 TranslateRankerFactory::GetForBrowserContext(profile);
41 if (!ranker)
42 continue;
43 ranker->EnableLogging(logging_enabled);
Roger McFarlane (Chromium) 2017/06/06 19:28:27 optional: if (ranker) ranker->EnableLogging(...
hamelphi 2017/06/06 20:28:05 Done.
44 }
45 }
46
47 void TranslateRankerMetricsProvider::OnRecordingEnabled() {
48 SetLoggingState(true);
49 }
50
51 void TranslateRankerMetricsProvider::OnRecordingDisabled() {
52 SetLoggingState(false);
53 }
54
35 } // namespace translate 55 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698