Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.cc
diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc
index 0b6a89e67b7255ca02b8d484bfbb135ac97318b5..b1d587f6c88133a015b11757ea18dba8fb76d4cd 100644
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -133,7 +133,7 @@ TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
const GURL& model_url,
ukm::UkmRecorder* ukm_recorder)
: ukm_recorder_(ukm_recorder),
- is_logging_enabled_(true),
+ is_logging_enabled_(false),
is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
is_enforcement_enabled_(
base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),
@@ -183,6 +183,10 @@ GURL TranslateRankerImpl::GetModelURL() {
}
void TranslateRankerImpl::EnableLogging(bool value) {
+ if (value != is_logging_enabled_) {
+ DVLOG(3) << "Cleared translate events cache.";
+ event_cache_.clear();
+ }
is_logging_enabled_ = value;
}

Powered by Google App Engine
This is Rietveld 408576698