components/translate/core/browser/translate_ranker_impl.h - Issue 2930433004: Send UMA recording state to TranslateRanker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_ranker_impl.h

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)

Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_ranker_impl.h

diff --git a/components/translate/core/browser/translate_ranker_impl.h b/components/translate/core/browser/translate_ranker_impl.h

index 61f30ea9b3a3baacb8debd484a1495472610c7fb..6211d4e105627fca5b4cdc8874e825035dd3ef7e 100644

--- a/components/translate/core/browser/translate_ranker_impl.h

+++ b/components/translate/core/browser/translate_ranker_impl.h

@@ -90,10 +90,8 @@ class TranslateRankerImpl : public TranslateRanker {

// from Finch.

static GURL GetModelURL();

- // Override the default enabled/disabled state of translate event logging.

- void EnableLogging(bool value);

// TranslateRanker...

+ void EnableLogging(bool value) override;

uint32_t GetModelVersion() const override;

bool ShouldOfferTranslation(

metrics::TranslateEventProto* translate_event) override;