Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker_impl.h" 5 #include "components/translate/core/browser/translate_ranker_impl.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 << "total_count=" << total_count << ", " 126 << "total_count=" << total_count << ", "
127 << "accept_ratio=" << accepted_ratio << ", " 127 << "accept_ratio=" << accepted_ratio << ", "
128 << "decline_ratio=" << denied_ratio << ", " 128 << "decline_ratio=" << denied_ratio << ", "
129 << "ignore_ratio=" << ignored_ratio; 129 << "ignore_ratio=" << ignored_ratio;
130 } 130 }
131 131
132 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path, 132 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
133 const GURL& model_url, 133 const GURL& model_url,
134 ukm::UkmRecorder* ukm_recorder) 134 ukm::UkmRecorder* ukm_recorder)
135 : ukm_recorder_(ukm_recorder), 135 : ukm_recorder_(ukm_recorder),
136 is_logging_enabled_(true), 136 is_logging_enabled_(false),
137 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)), 137 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
138 is_enforcement_enabled_( 138 is_enforcement_enabled_(
139 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)), 139 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),
140 is_decision_override_enabled_(base::FeatureList::IsEnabled( 140 is_decision_override_enabled_(base::FeatureList::IsEnabled(
141 translate::kTranslateRankerDecisionOverride)), 141 translate::kTranslateRankerDecisionOverride)),
142 weak_ptr_factory_(this) { 142 weak_ptr_factory_(this) {
143 if (is_query_enabled_ || is_enforcement_enabled_) { 143 if (is_query_enabled_ || is_enforcement_enabled_) {
144 model_loader_ = base::MakeUnique<RankerModelLoader>( 144 model_loader_ = base::MakeUnique<RankerModelLoader>(
145 base::Bind(&ValidateModel), 145 base::Bind(&ValidateModel),
146 base::Bind(&TranslateRankerImpl::OnModelAvailable, 146 base::Bind(&TranslateRankerImpl::OnModelAvailable,
(...skipping 29 matching lines...) Expand all
176 raw_url = variations::GetVariationParamValueByFeature( 176 raw_url = variations::GetVariationParamValueByFeature(
177 kTranslateRankerQuery, switches::kTranslateRankerModelURL); 177 kTranslateRankerQuery, switches::kTranslateRankerModelURL);
178 } 178 }
179 179
180 DVLOG(3) << switches::kTranslateRankerModelURL << " = " << raw_url; 180 DVLOG(3) << switches::kTranslateRankerModelURL << " = " << raw_url;
181 181
182 return GURL(raw_url); 182 return GURL(raw_url);
183 } 183 }
184 184
185 void TranslateRankerImpl::EnableLogging(bool value) { 185 void TranslateRankerImpl::EnableLogging(bool value) {
186 if (value != is_logging_enabled_) {
187 DVLOG(3) << "Cleared translate events cache.";
188 event_cache_.clear();
189 }
186 is_logging_enabled_ = value; 190 is_logging_enabled_ = value;
187 } 191 }
188 192
189 uint32_t TranslateRankerImpl::GetModelVersion() const { 193 uint32_t TranslateRankerImpl::GetModelVersion() const {
190 return model_ ? model_->proto().translate().version() : 0; 194 return model_ ? model_->proto().translate().version() : 0;
191 } 195 }
192 196
193 bool TranslateRankerImpl::ShouldOfferTranslation( 197 bool TranslateRankerImpl::ShouldOfferTranslation(
194 metrics::TranslateEventProto* translate_event) { 198 metrics::TranslateEventProto* translate_event) {
195 DCHECK(sequence_checker_.CalledOnValidSequence()); 199 DCHECK(sequence_checker_.CalledOnValidSequence());
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 } 369 }
366 } 370 }
367 371
368 } // namespace translate 372 } // namespace translate
369 373
370 std::ostream& operator<<(std::ostream& stream, 374 std::ostream& operator<<(std::ostream& stream,
371 const translate::TranslateRankerFeatures& features) { 375 const translate::TranslateRankerFeatures& features) {
372 features.WriteTo(stream); 376 features.WriteTo(stream);
373 return stream; 377 return stream;
374 } 378 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698