Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2930423002: Mojo JS bindings: convert relative path to URL properly. (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: convert relative path to URL properly. BUG=699569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2930423002 Cr-Commit-Position: refs/heads/master@{#479006} Committed: https://chromium.googlesource.com/chromium/src/+/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 :  #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/echo.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/interfaces/bindings/tests/echo_import.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/echo_import/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/echo_import/echo_import.mojom View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 6 months ago (2017-06-13 00:27:59 UTC) #5
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-13 13:39:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930423002/40001
3 years, 6 months ago (2017-06-13 14:09:42 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 14:14:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c4ddb86f7b07335a3a02e1ce5a37...

Powered by Google App Engine
This is Rietveld 408576698