Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 2930423002: Mojo JS bindings: convert relative path to URL properly. (Closed)
Patch Set:  Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/mojom_js_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py
index a6e31340c72cdd77ff1f9c7a07fd2432260fa68b..969a055be0fe8a1198fa44692fb6ead92b185d97 100644
--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py
@@ -8,6 +8,7 @@ import mojom.generate.generator as generator
import mojom.generate.module as mojom
import mojom.generate.pack as pack
import os
+import urllib
from mojom.generate.template_expander import UseJinja
_kind_to_javascript_default_value = {
@@ -88,8 +89,9 @@ def GetArrayExpectedDimensionSizes(kind):
return expected_dimension_sizes
-def GetRelativePath(module, base_module):
- return os.path.relpath(module.path, os.path.dirname(base_module.path))
+def GetRelativeUrl(module, base_module):
+ return urllib.pathname2url(
+ os.path.relpath(module.path, os.path.dirname(base_module.path)))
class JavaScriptStylizer(generator.Stylizer):
@@ -140,7 +142,7 @@ class Generator(generator.Generator):
"encode_snippet": self._JavaScriptEncodeSnippet,
"expression_to_text": self._ExpressionToText,
"field_offset": JavaScriptFieldOffset,
- "get_relative_path": GetRelativePath,
+ "get_relative_url": GetRelativeUrl,
"has_callbacks": mojom.HasCallbacks,
"is_any_handle_or_interface_kind": mojom.IsAnyHandleOrInterfaceKind,
"is_array_kind": mojom.IsArrayKind,

Powered by Google App Engine
This is Rietveld 408576698