Convert ozone/drm DisplaySnapshot_Param to DisplaySnapshotMojo

Convert ozone/drm DisplaySnapshot_Param to DisplaySnapshotMojo

In ozone/drm, modify DrmThread::RefreshNativeDisplay to use
DisplaySnapshotMojo. This is another incremental step in using mojo
communication in ozone/drm. In particular, using the DrmThread as an
implementation of a mojo interface for cursor, display and buffer
control.

BUG=620927
Review-Url: https://codereview.chromium.org/2930163002
Cr-Commit-Position: refs/heads/master@{#479152}
Committed: https://chromium.googlesource.com/chromium/src/+/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0

[rjkroege, 2017-06-10 00:16:54]

rjkroege@chromium.org changed reviewers:
+ dnicoara@chromium.org

[rjkroege, 2017-06-10 00:16:55]

ptal

[dnicoara, 2017-06-12 15:05:26]

lgtm % nits

https://codereview.chromium.org/2930163002/diff/1/ui/display/types/display_sn...
File ui/display/types/display_snapshot_mojo.h (right):

https://codereview.chromium.org/2930163002/diff/1/ui/display/types/display_sn...
ui/display/types/display_snapshot_mojo.h:53: 
Delete empty line.

https://codereview.chromium.org/2930163002/diff/1/ui/ozone/platform/drm/commo...
File ui/ozone/platform/drm/common/drm_util_unittest.cc (right):

https://codereview.chromium.org/2930163002/diff/1/ui/ozone/platform/drm/commo...
ui/ozone/platform/drm/common/drm_util_unittest.cc:14: bool operator==(const
ui::DisplayMode_Params& a,
Why aren't these helper functions in the anonymous namespace?

[rjkroege, 2017-06-12 20:04:38]

rjkroege@chromium.org changed reviewers:
+ derat@chromium.org

[rjkroege, 2017-06-12 20:04:38]

nits fixed.

+derat for ui/display OWNERS

https://codereview.chromium.org/2930163002/diff/1/ui/display/types/display_sn...
File ui/display/types/display_snapshot_mojo.h (right):

https://codereview.chromium.org/2930163002/diff/1/ui/display/types/display_sn...
ui/display/types/display_snapshot_mojo.h:53: 
On 2017/06/12 15:05:26, dnicoara wrote:
> Delete empty line.

Done.

https://codereview.chromium.org/2930163002/diff/1/ui/ozone/platform/drm/commo...
File ui/ozone/platform/drm/common/drm_util_unittest.cc (right):

https://codereview.chromium.org/2930163002/diff/1/ui/ozone/platform/drm/commo...
ui/ozone/platform/drm/common/drm_util_unittest.cc:14: bool operator==(const
ui::DisplayMode_Params& a,
On 2017/06/12 15:05:26, dnicoara wrote:
> Why aren't these helper functions in the anonymous namespace?

gtest can't look into the anonymous namespace for the implementation of ==.

DetailedCompare can be. Moved.

[Daniel Erat, 2017-06-12 21:14:16]

lgtm for ui/display

[rjkroege, 2017-06-12 21:19:21]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-06-12 21:19:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/2930163002/#ps20001
(title: "review nits")

[commit-bot: I haz the power, 2017-06-12 21:19:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 23:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:23:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rjkroege, 2017-06-13 20:04:55]

The CQ bit was checked by rjkroege@chromium.org

[commit-bot: I haz the power, 2017-06-13 20:05:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:18:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497384295279030,
"parent_rev": "416d4662161039614056b0f9f14692185063734a", "commit_rev":
"dd2587383919cd365bc3b8b81dfdff78cf3b6eb0"}

[commit-bot: I haz the power, 2017-06-13 21:18:22]

Description was changed from

==========
Convert ozone/drm DisplaySnapshot_Param to DisplaySnapshotMojo

In ozone/drm, modify DrmThread::RefreshNativeDisplay to use
DisplaySnapshotMojo. This is another incremental step in using mojo
communication in ozone/drm. In particular, using the DrmThread as an
implementation of a mojo interface for cursor, display and buffer
control.

BUG=620927
==========

to

==========
Convert ozone/drm DisplaySnapshot_Param to DisplaySnapshotMojo

In ozone/drm, modify DrmThread::RefreshNativeDisplay to use
DisplaySnapshotMojo. This is another incremental step in using mojo
communication in ozone/drm. In particular, using the DrmThread as an
implementation of a mojo interface for cursor, display and buffer
control.

BUG=620927

Review-Url: https://codereview.chromium.org/2930163002
Cr-Commit-Position: refs/heads/master@{#479152}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd2587383919cd365bc3b8b81dfd...
==========

[commit-bot: I haz the power, 2017-06-13 21:18:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd2587383919cd365bc3b8b81dfd...