Refactoring bookmark viewcontrollers

Refactoring bookmark viewcontrollers

BookmarkHomeHandsetViewController and BookmarkHomeTabletNTPController
have a lot of overlap in terms of business logic, and hence results
in maintenance overhead. This effort is to refactor the classes so that
they have a common super class with the core logic.

This is CL#1: Merge existing BookmarkHomeViewController and
BookmarkHomeHandsetViewController into one class.

See go/bookmarks-refactor for more details.

BUG=705339
Review-Url: https://codereview.chromium.org/2929993002
Cr-Commit-Position: refs/heads/master@{#478918}
Committed: https://chromium.googlesource.com/chromium/src/+/742eb0b40de63b805481c7816f4de124d46211af

[ramyasharma, 2017-06-09 04:27:45]

The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 04:27:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 05:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 05:34:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ramyasharma, 2017-06-09 05:43:02]

ramyasharma@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2017-06-12 08:29:11]

lgtm.

[ramyasharma, 2017-06-13 05:55:51]

The CQ bit was checked by ramyasharma@chromium.org

[commit-bot: I haz the power, 2017-06-13 05:56:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 07:11:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497333351189940, "parent_rev":
"0ca6ede735839db5f4391fc4f14337e6f32f2c6b", "commit_rev":
"742eb0b40de63b805481c7816f4de124d46211af"}

[commit-bot: I haz the power, 2017-06-13 07:11:08]

Description was changed from

==========
Refactoring bookmark viewcontrollers

BookmarkHomeHandsetViewController and BookmarkHomeTabletNTPController
have a lot of overlap in terms of business logic, and hence results
in maintenance overhead. This effort is to refactor the classes so that
they have a common super class with the core logic.

This is CL#1: Merge existing BookmarkHomeViewController and
BookmarkHomeHandsetViewController into one class.

See go/bookmarks-refactor for more details.

BUG=705339
==========

to

==========
Refactoring bookmark viewcontrollers

BookmarkHomeHandsetViewController and BookmarkHomeTabletNTPController
have a lot of overlap in terms of business logic, and hence results
in maintenance overhead. This effort is to refactor the classes so that
they have a common super class with the core logic.

This is CL#1: Merge existing BookmarkHomeViewController and
BookmarkHomeHandsetViewController into one class.

See go/bookmarks-refactor for more details.

BUG=705339

Review-Url: https://codereview.chromium.org/2929993002
Cr-Commit-Position: refs/heads/master@{#478918}
Committed:
https://chromium.googlesource.com/chromium/src/+/742eb0b40de63b805481c7816f4d...
==========

[commit-bot: I haz the power, 2017-06-13 07:11:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/742eb0b40de63b805481c7816f4d...