Refactoring bookmark viewcontrollers

ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h"
 
 #include <memory>
 
 #include "base/logging.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/strings/grit/components_strings.h"
 #include "google_apis/gaia/google_service_auth_error.h"
+#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "ios/chrome/browser/bookmarks/bookmarks_utils.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #import "ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h"
 #import "ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.h"
 #import "ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h"
@@ skipping 29 matching lines @@
     BookmarkFolderEditorViewControllerDelegate,
     BookmarkFolderViewControllerDelegate,
     BookmarkMenuViewDelegate,
     BookmarkModelBridgeObserver,
     BookmarkPanelViewDelegate,
     BookmarkPromoControllerDelegate> {
   // Bridge to register for bookmark changes.
   std::unique_ptr<bookmarks::BookmarkModelBridge> _bridge;
 }
 
+// Redefined to be readwrite.
+@property(nonatomic, strong, readwrite) NSMutableArray* editIndexPaths;
+
+// Returns the parent, if all the bookmarks are siblings.
+// Otherwise returns the mobile_node.
++ (const BookmarkNode*)
+defaultMoveFolderFromBookmarks:(const std::set<const BookmarkNode*>&)bookmarks
+                         model:(bookmarks::BookmarkModel*)model;
+
 // This views holds the primary content of this view controller. At any point in
 // time, it contains exactly one of the BookmarkCollectionView subclasses.
 @property(nonatomic, strong) UIView* contentView;
 // The possible views that can be shown from the menu.
 @property(nonatomic, strong) BookmarkFolderCollectionView* folderView;
 // This view is created and used if the model is not fully loaded yet by the
 // time this controller starts.
 @property(nonatomic, strong) BookmarkHomeWaitingView* waitForModelView;
 
 // The menu with all the folders and special entries.
@@ skipping 152 matching lines @@
 
 @synthesize actionSheetCoordinator = _actionSheetCoordinator;
 @synthesize editViewController = _editViewController;
 @synthesize folderSelector = _folderSelector;
 @synthesize folderEditor = _folderEditor;
 
 @synthesize panelView = _panelView;
 @synthesize scrollingMenuToTop = _scrollingMenuToTop;
 @synthesize bookmarkPromoController = _bookmarkPromoController;
 
+@synthesize delegate = _delegate;
+@synthesize editIndexPaths = _editIndexPaths;
+@synthesize editing = _editing;
+@synthesize bookmarks = _bookmarks;
+@synthesize loader = _loader;
+@synthesize browserState = _browserState;
+
 - (instancetype)initWithLoader:(id<UrlLoader>)loader
                   browserState:(ios::ChromeBrowserState*)browserState {
-  self = [super initWithLoader:loader browserState:browserState];
+  DCHECK(browserState);
+  self = [super initWithNibName:nil bundle:nil];
   if (self) {
+    _browserState = browserState->GetOriginalChromeBrowserState();
+    _loader = loader;
+
+    _bookmarks = ios::BookmarkModelFactory::GetForBrowserState(_browserState);
+    _editIndexPaths = [[NSMutableArray alloc] init];
+
+    [self resetEditNodes];
+
     _bridge.reset(new bookmarks::BookmarkModelBridge(self, self.bookmarks));
     // It is important to initialize the promo controller with the browser state
     // passed in, as it could be incognito.
     _bookmarkPromoController =
         [[BookmarkPromoController alloc] initWithBrowserState:browserState
                                                      delegate:self];
   }
   return self;
 }
 
 - (void)dealloc {
   _folderView.delegate = nil;
 
   _menuView.delegate = nil;
 
   _editViewController.delegate = nil;
   _folderSelector.delegate = nil;
 
   _panelView.delegate = nil;
 }
 
+- (void)loadView {
+  CGRect frame = [[UIScreen mainScreen] bounds];
+  self.view = [[UIView alloc] initWithFrame:frame];
+}
+
+- (void)resetEditNodes {
+  _editNodes = std::set<const BookmarkNode*>();
+  _editNodesOrdered = std::vector<const BookmarkNode*>();
+  [self.editIndexPaths removeAllObjects];
+}
+
+- (void)insertEditNode:(const BookmarkNode*)node
+           atIndexPath:(NSIndexPath*)indexPath {
+  if (_editNodes.find(node) != _editNodes.end())
+    return;
+  _editNodes.insert(node);
+  _editNodesOrdered.push_back(node);
+  if (indexPath) {
+    [self.editIndexPaths addObject:indexPath];
+  } else {
+    // We insert null if we don't have the cell to keep the index valid.
+    [self.editIndexPaths addObject:[NSNull null]];
+  }
+}
+
+- (void)removeEditNode:(const BookmarkNode*)node
+           atIndexPath:(NSIndexPath*)indexPath {
+  if (_editNodes.find(node) == _editNodes.end())
+    return;
+
+  _editNodes.erase(node);
+  std::vector<const BookmarkNode*>::iterator it =
+      std::find(_editNodesOrdered.begin(), _editNodesOrdered.end(), node);
+  DCHECK(it != _editNodesOrdered.end());
+  _editNodesOrdered.erase(it);
+  if (indexPath) {
+    [self.editIndexPaths removeObject:indexPath];
+  } else {
+    // If we don't have the cell, we remove it by using its index.
+    const NSUInteger index = std::distance(_editNodesOrdered.begin(), it);
+    if (index < self.editIndexPaths.count) {
+      [self.editIndexPaths removeObjectAtIndex:index];
+    }
+  }
+}
+
 - (void)removeEditNode:(const BookmarkNode*)node
                   cell:(UICollectionViewCell*)cell {
-  [super removeEditNode:node atIndexPath:[self indexPathForCell:cell]];
+  [self removeEditNode:node atIndexPath:[self indexPathForCell:cell]];
+
   if (_editNodes.size() == 0)
     [self setEditing:NO animated:YES];
   else
     [self updateEditingStateAnimated:YES];
 }
 
 #pragma mark - UIViewController methods
 
 - (void)viewDidLoad {
   [super viewDidLoad];
@@ skipping 177 matching lines @@
   }
   [self.editingBar updateUIWithBookmarkCount:bookmarkCount
                                  folderCount:folderCount];
 
   [self showEditingBarAnimated:animated];
   [self updateEditBarShadow];
   [self.panelView enableSideSwiping:NO];
 }
 
 - (void)setEditing:(BOOL)editing animated:(BOOL)animated {
-  [super setEditing:editing animated:animated];
+  if (_editing == editing)
+    return;
+
+  _editing = editing;
+
+  // Only reset the editing state when leaving edit mode. This allows subclasses
+  // to add nodes for editing before entering edit mode.
+  if (!editing)
+    [self resetEditNodes];
 
   [self updateEditingStateAnimated:animated];
   if ([[self primaryMenuItem] supportsEditing])
     [[self primaryView] setEditing:editing animated:animated];
 
   if (editing)
     self.bookmarkPromoController.promoState = NO;
   else
     [self.bookmarkPromoController updatePromoState];
 }
@@ skipping 482 matching lines @@
   [self.menuView setScrollsToTop:NO];
   [[self primaryView] setScrollsToTop:YES];
   self.scrollingMenuToTop = NO;
   [self.panelView hideMenuAnimated:animated];
   if (update) {
     UIInterfaceOrientation orient = GetInterfaceOrientation();
     [self updateNavigationBarAnimated:animated orientation:orient];
   }
 }
 
-#pragma mark - BookmarkHomeViewController
-
 - (void)dismissModals:(BOOL)animated {
   [self.actionSheetCoordinator stop];
   self.actionSheetCoordinator = nil;
 }
 
 #pragma mark - BookmarkPanelViewDelegate
 
 - (void)bookmarkPanelView:(BookmarkPanelView*)view
              willShowMenu:(BOOL)showMenu
     withAnimationDuration:(CGFloat)duration {
@@ skipping 119 matching lines @@
 }
 
 #pragma mark - Internal non-UI Methods
 
 - (void)delegateDismiss:(const GURL&)url {
   if ([self primaryView]) {
     bookmark_utils_ios::CachePosition(
         [[self primaryView] contentPositionInPortraitOrientation],
         [self primaryMenuItem]);
   }
-  [self.delegate bookmarkHomeViewControllerWantsDismissal:self
-                                          navigationToUrl:url];
+  [self.delegate bookmarkHomeHandsetViewControllerWantsDismissal:self
+                                                 navigationToUrl:url];
 }
 
 #pragma mark - BookmarkPromoControllerDelegate
 
 - (void)promoStateChanged:(BOOL)promoEnabled {
   [self.folderView
       promoStateChangedAnimated:self.folderView == [self primaryView]];
 }
 
 - (NSIndexPath*)indexPathForCell:(UICollectionViewCell*)cell {
   DCHECK([self primaryView].collectionView);
   NSIndexPath* indexPath =
       [[self primaryView].collectionView indexPathForCell:cell];
   return indexPath;
 }
 
++ (const BookmarkNode*)
+defaultMoveFolderFromBookmarks:(const std::set<const BookmarkNode*>&)bookmarks
+                         model:(bookmarks::BookmarkModel*)model {
+  if (bookmarks.size() == 0)
+    return model->mobile_node();
+  const BookmarkNode* firstParent = (*(bookmarks.begin()))->parent();
+  for (const BookmarkNode* node : bookmarks) {
+    if (node->parent() != firstParent)
+      return model->mobile_node();
+  }
+
+  return firstParent;
+}
+
 @end
+
+@implementation BookmarkHomeHandsetViewController (ExposedForTesting)
+
+- (void)ensureAllViewExists {
+  // Do nothing.
+}
+
+- (const std::set<const BookmarkNode*>&)editNodes {
+  return _editNodes;
+}
+
+- (void)setEditNodes:(const std::set<const BookmarkNode*>&)editNodes {
+  _editNodes = editNodes;
+}
+
+@end