Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2929773002: Mac: Remove create_application_shortcut_cocoa.mm (Closed)

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, srahim+watch_chromium.org, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Remove create_application_shortcut_cocoa.mm On Mac, the dialog doesn't give any choice to the user, so assume they will make the only choice they can make, which is to make a shortcut. Remove trailing ellipses from the UI surface that invokes this on Mac. BUG=728153 Review-Url: https://codereview.chromium.org/2929773002 Cr-Commit-Position: refs/heads/master@{#478212} Committed: https://chromium.googlesource.com/chromium/src/+/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87

Patch Set 1 #

Patch Set 2 : One less file #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -178 lines) Patch
M chrome/app/generated_resources.grd View 5 chunks +34 lines, -38 lines 2 comments Download
M chrome/browser/ui/BUILD.gn View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm View 1 1 chunk +0 lines, -135 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 1 chunk +17 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
tapted
Hi Ben, please take a look.
3 years, 6 months ago (2017-06-09 01:11:56 UTC) #7
tapted
https://codereview.chromium.org/2929773002/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2929773002/diff/20001/chrome/app/generated_resources.grd#newcode2057 chrome/app/generated_resources.grd:2057: </if> the diff came out a bit confusing.. summary: ...
3 years, 6 months ago (2017-06-09 01:15:33 UTC) #8
benwells
lgtm https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_applications/web_app_mac.mm File chrome/browser/web_applications/web_app_mac.mm (right): https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_applications/web_app_mac.mm#newcode1119 chrome/browser/web_applications/web_app_mac.mm:1119: void ShowCreateChromeAppShortcutsDialog( Hmmm .. this name is unfortunate. ...
3 years, 6 months ago (2017-06-09 04:28:53 UTC) #9
tapted
Thanks Ben! https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_applications/web_app_mac.mm File chrome/browser/web_applications/web_app_mac.mm (right): https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_applications/web_app_mac.mm#newcode1119 chrome/browser/web_applications/web_app_mac.mm:1119: void ShowCreateChromeAppShortcutsDialog( On 2017/06/09 04:28:52, benwells wrote: ...
3 years, 6 months ago (2017-06-09 05:47:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929773002/20001
3 years, 6 months ago (2017-06-09 05:47:23 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 05:51:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b82aa8c13c7fb73b0e1931adc13...

Powered by Google App Engine
This is Rietveld 408576698