Mac: Remove create_application_shortcut_cocoa.mm

Mac: Remove create_application_shortcut_cocoa.mm

On Mac, the dialog doesn't give any choice to the user, so assume they
will make the only choice they can make, which is to make a shortcut.

Remove trailing ellipses from the UI surface that invokes this on Mac.

BUG=728153
Review-Url: https://codereview.chromium.org/2929773002
Cr-Commit-Position: refs/heads/master@{#478212}
Committed: https://chromium.googlesource.com/chromium/src/+/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87

[tapted, 2017-06-08 07:50:13]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 07:50:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-08 07:52:44]

Description was changed from

==========
Just kill the dialog

BUG=728153
==========

to

==========
Mac: Remove create_application_shortcut_cocoa.mm

On Mac, the dialog doesn't give any choice to the user, so assume they
will make the only choice they can make, which is to make a shortcut.

Remove trailing ellipses from the UI surface that invokes this on Mac.

BUG=728153
==========

[tapted, 2017-06-08 07:52:44]

tapted@chromium.org changed reviewers:
+ benwells@chromium.org

[commit-bot: I haz the power, 2017-06-08 10:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 10:07:22]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tapted, 2017-06-09 01:11:56]

Hi Ben, please take a look.

[tapted, 2017-06-09 01:15:33]

https://codereview.chromium.org/2929773002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2929773002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:2057: </if>
the diff came out a bit confusing..
summary: the "if" block that ends here is `expr="not is_macosx"` - I moved
IDS_CREATE_SHORTCUTS_COMMIT from below into it and indented the rest

https://codereview.chromium.org/2929773002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:8401: </message>
note the old `if expr="is_macosx"` would never have been used since
use_titlecase is always true on mac

[benwells, 2017-06-09 04:28:53]

lgtm

https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_appl...
File chrome/browser/web_applications/web_app_mac.mm (right):

https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_appl...
chrome/browser/web_applications/web_app_mac.mm:1119: void
ShowCreateChromeAppShortcutsDialog(
Hmmm .. this name is unfortunate. I guess it doesn't matter given the future of
Chrome Apps on Mac.

[tapted, 2017-06-09 05:47:03]

Thanks Ben!

https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_appl...
File chrome/browser/web_applications/web_app_mac.mm (right):

https://codereview.chromium.org/2929773002/diff/20001/chrome/browser/web_appl...
chrome/browser/web_applications/web_app_mac.mm:1119: void
ShowCreateChromeAppShortcutsDialog(
On 2017/06/09 04:28:52, benwells wrote:
> Hmmm .. this name is unfortunate. I guess it doesn't matter given the future
of
> Chrome Apps on Mac.

Acknowledged.

[tapted, 2017-06-09 05:47:06]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-06-09 05:47:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 05:51:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496987226721440,
"parent_rev": "feef72d0d19c8336b0199b6b7c8ad10b0251f675", "commit_rev":
"2b82aa8c13c7fb73b0e1931adc1388a0ce986a87"}

[commit-bot: I haz the power, 2017-06-09 05:51:26]

Description was changed from

==========
Mac: Remove create_application_shortcut_cocoa.mm

On Mac, the dialog doesn't give any choice to the user, so assume they
will make the only choice they can make, which is to make a shortcut.

Remove trailing ellipses from the UI surface that invokes this on Mac.

BUG=728153
==========

to

==========
Mac: Remove create_application_shortcut_cocoa.mm

On Mac, the dialog doesn't give any choice to the user, so assume they
will make the only choice they can make, which is to make a shortcut.

Remove trailing ellipses from the UI surface that invokes this on Mac.

BUG=728153

Review-Url: https://codereview.chromium.org/2929773002
Cr-Commit-Position: refs/heads/master@{#478212}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b82aa8c13c7fb73b0e1931adc13...
==========

[commit-bot: I haz the power, 2017-06-09 05:51:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b82aa8c13c7fb73b0e1931adc13...