Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Issue 2929773002: Mac: Remove create_application_shortcut_cocoa.mm (Closed)
Patch Set: One less file Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/web_applications/web_app_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 4a65615c514c6d7a105ab3bda3c4b75f898dca60..41f52ed5cf3d41b11eb5eaa6f40927ab8eb84d70 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -1991,9 +1991,16 @@ From <ph name="DOWNLOAD_DOMAIN">$3<ex>example.com</ex></ph>
<message name="IDS_APPLICATION_INFO_VERSION_LABEL" desc="In Title Case: Text displayed before the app or extension's version in the details section of the dialog.">
Version:
</message>
- <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that opens the dialog to create shortcuts for the app.">
+ <if expr="is_macosx">
+ <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that creates a shortcut for the app.">
+ Create Shortcut
+ </message>
+ </if>
+ <if expr="not is_macosx">
+ <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that opens the dialog to create shortcuts for the app.">
Create Shortcuts...
- </message>
+ </message>
+ </if>
</if>
<message name="IDS_APPLICATION_INFO_SIZE_LOADING_LABEL" desc="Text displayed instead of the app or extension's size on disk in the details section of the dialog while the size is being calculated.">
Calculating...
@@ -2024,28 +2031,28 @@ From <ph name="DOWNLOAD_DOMAIN">$3<ex>example.com</ex></ph>
</message>
<!-- "Create application shortcuts" dialog -->
- <if expr="not use_titlecase">
- <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="Title of the dialog to create application shortcuts for current page.">
- Create application shortcuts
+ <if expr="not is_macosx">
+ <if expr="not use_titlecase">
+ <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="Title of the dialog to create application shortcuts for current page.">
+ Create application shortcuts
+ </message>
+ </if>
+ <if expr="use_titlecase">
+ <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="In Title Case: title of the dialog to create application shortcuts for current page.">
+ Create Application Shortcuts
+ </message>
+ </if>
+ <message name="IDS_CREATE_SHORTCUTS_LABEL" desc="Contents of the main label in the create application shortcuts dialog explaining the dialog.">
+ Add shortcuts to the following places:
</message>
- </if>
- <if expr="use_titlecase">
- <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="In Title Case: title of the dialog to create application shortcuts for current page.">
- Create Application Shortcuts
+ <message name="IDS_CREATE_SHORTCUTS_DESKTOP_CHKBOX" desc="Label of the checkbox to create an application shortcut on the desktop.">
+ Desktop
</message>
- </if>
- <message name="IDS_CREATE_SHORTCUTS_LABEL" desc="Contents of the main label in the create application shortcuts dialog explaining the dialog.">
- Add shortcuts to the following places:
- </message>
- <message name="IDS_CREATE_SHORTCUTS_DESKTOP_CHKBOX" desc="Label of the checkbox to create an application shortcut on the desktop.">
- Desktop
- </message>
- <message name="IDS_CREATE_SHORTCUTS_MENU_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications menu.">
- Applications menu
- </message>
- <if expr="is_macosx">
- <message name="IDS_CREATE_SHORTCUTS_APP_FOLDER_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications folder.">
- Applications folder
+ <message name="IDS_CREATE_SHORTCUTS_MENU_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications menu.">
+ Applications menu
+ </message>
+ <message name="IDS_CREATE_SHORTCUTS_COMMIT" desc="Title of the button to actually create the shortcuts.">
+ Create
</message>
</if>
tapted 2017/06/09 01:15:33 the diff came out a bit confusing.. summary: the "
<if expr="is_win">
@@ -2059,9 +2066,6 @@ From <ph name="DOWNLOAD_DOMAIN">$3<ex>example.com</ex></ph>
Pin to Taskbar
</message>
</if>
- <message name="IDS_CREATE_SHORTCUTS_COMMIT" desc="Title of the button to actually create the shortcuts.">
- Create
- </message>
<!-- Web Share Target picker dialog -->
<if expr="not use_titlecase">
@@ -8391,18 +8395,10 @@ I don't think this site should be blocked!
desc="Text for the context menu item that takes the user to the app in Web Store. (In sentence case.)">
View in Web Store
</message>
- <if expr="is_macosx">
- <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
- desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
- Create shortcut...
- </message>
- </if>
- <if expr="not is_macosx">
- <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
- desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
- Create shortcuts...
- </message>
- </if>
+ <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
+ desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
+ Create shortcuts...
+ </message>
tapted 2017/06/09 01:15:33 note the old `if expr="is_macosx"` would never hav
<message name="IDS_APP_CONTEXT_MENU_SHOW_INFO"
desc="Text for the context menu item that shows the application information. (In sentence case.)">
App info
@@ -8451,7 +8447,7 @@ I don't think this site should be blocked!
<if expr="is_macosx">
<message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
desc="Text for the context menu item that creates an app shortcut. (In title case.)">
- Create Shortcut...
+ Create Shortcut
</message>
</if>
<if expr="not is_macosx">
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/web_applications/web_app_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698