Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2929763002: Introduce InlineTextBoxesOf() for ease of loop over InlineTextBox of LayoutText (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent, kojii
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce InlineTextBoxesOf() for ease of loop over InlineTextBox of LayoutText This patch Introduces |InlineTextBoxesOf()| to simplify pattern: for (InlineTextBox* box = layout_text->FirstTextBox(); box; box = box->NextTextBox()) to for (InlineTextBox* box : InlineTextBoxesOf(*layout_text)) for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2929763002 Cr-Commit-Position: refs/heads/master@{#477933} Committed: https://chromium.googlesource.com/chromium/src/+/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf

Patch Set 1 : 2017-06-08T14:33:23 #

Patch Set 2 : 2017-06-08T17:21:30 Revise variable name in ComputeInlineBoxPositionTempalte to make patch size smaller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -49 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 6 chunks +14 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 2 chunks +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 16 chunks +37 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-08 07:03:19 UTC) #5
tkent
lgtm
3 years, 6 months ago (2017-06-08 07:55:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929763002/20001
3 years, 6 months ago (2017-06-08 08:25:22 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 09:58:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23804ef2df58586b1e2e6ccaf0f0...

Powered by Google App Engine
This is Rietveld 408576698