third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp - Issue 2929763002: Introduce InlineTextBoxesOf() for ease of loop over InlineTextBox of LayoutText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

Issue 2929763002: Introduce InlineTextBoxesOf() for ease of loop over InlineTextBox of LayoutText (Closed)

Patch Set: 2017-06-08T17:21:30 Revise variable name in ComputeInlineBoxPositionTempalte to make patch size smaller Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

index 10d340b977448843fabff0bbf4e62664593e10a2..e4bf6aeffaf43c2e7c4fd68178a07ba42be38811 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

@@ -175,8 +175,7 @@ void TextIteratorTextNodeHandler::HandleTextNodeInRange(Text* node,

// Used when text boxes are out of order (Hebrew/Arabic w/ embeded LTR text)

if (layout_object->ContainsReversedText()) {

sorted_text_boxes_.clear();

- for (InlineTextBox* text_box = layout_object->FirstTextBox(); text_box;

- text_box = text_box->NextTextBox()) {

+ for (InlineTextBox* text_box : InlineTextBoxesOf(*layout_object)) {

sorted_text_boxes_.push_back(text_box);

}

std::sort(sorted_text_boxes_.begin(), sorted_text_boxes_.end(),