MD Settings: Fix search highlighting within extension-controlled-indicator.

MD Settings: Fix search highlighting within extension-controlled-indicator.

Make the CSS rule for span more specific, such that it is not accidentally
applied to the <span> used for search highlights.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2929683002
Cr-Commit-Position: refs/heads/master@{#477854}
Committed: https://chromium.googlesource.com/chromium/src/+/0fbb54abf28e52285f1b4ee260c3023fb3fea6ab

[dpapad, 2017-06-07 22:52:24]

Description was changed from

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

BUG=730534
==========

to

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-07 22:53:11]

Description was changed from

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

Make the CSS rule for span more specific, such that it is not accidentally
applied to the <span> used for search highlights.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-07 22:53:55]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-06-07 22:54:28]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2017-06-07 22:54:29]

Before/after screenshots at http://imgur.com/a/WUwgG.

[commit-bot: I haz the power, 2017-06-07 22:54:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-07 23:00:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 23:00:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-07 23:33:06]

lgtm

https://codereview.chromium.org/2929683002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/controls/extension_controlled_indicator.html
(right):

https://codereview.chromium.org/2929683002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/extension_controlled_indicator.html:26:
when search "hit" occurs within this element. */
Nit: It seems common to start comment lines with 
 * 
after the first line. I don't recall it specifically mentioned in the style
guide, so it's up to you.

[dpapad, 2017-06-08 00:03:59]

https://codereview.chromium.org/2929683002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/controls/extension_controlled_indicator.html
(right):

https://codereview.chromium.org/2929683002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/extension_controlled_indicator.html:26:
when search "hit" occurs within this element. */
On 2017/06/07 at 23:33:06, dschuyler wrote:
> Nit: It seems common to start comment lines with 
>  * 
> after the first line. I don't recall it specifically mentioned in the style
guide, so it's up to you.

Done.

[dpapad, 2017-06-08 00:04:03]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-06-08 00:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2929683002/#ps40001
(title: "Nits.")

[commit-bot: I haz the power, 2017-06-08 00:04:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 01:39:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496880243181590,
"parent_rev": "cb07eaab8439b08cf2567734b090d447a208bfb4", "commit_rev":
"0fbb54abf28e52285f1b4ee260c3023fb3fea6ab"}

[commit-bot: I haz the power, 2017-06-08 01:40:07]

Description was changed from

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

Make the CSS rule for span more specific, such that it is not accidentally
applied to the <span> used for search highlights.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix search highlighting within extension-controlled-indicator.

Make the CSS rule for span more specific, such that it is not accidentally
applied to the <span> used for search highlights.

BUG=730534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2929683002
Cr-Commit-Position: refs/heads/master@{#477854}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fbb54abf28e52285f1b4ee260c3...
==========

[commit-bot: I haz the power, 2017-06-08 01:40:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0fbb54abf28e52285f1b4ee260c3...