Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/resources/settings/controls/extension_controlled_indicator.html

Issue 2929683002: MD Settings: Fix search highlighting within extension-controlled-indicator. (Closed)
Patch Set: Add explanatory comment. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 3 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="../extension_control_browser_proxy.html"> 5 <link rel="import" href="../extension_control_browser_proxy.html">
6 <link rel="import" href="../i18n_setup.html"> 6 <link rel="import" href="../i18n_setup.html">
7 <link rel="import" href="../settings_shared_css.html"> 7 <link rel="import" href="../settings_shared_css.html">
8 8
9 <dom-module id="extension-controlled-indicator"> 9 <dom-module id="extension-controlled-indicator">
10 <template> 10 <template>
11 <style include="settings-shared"> 11 <style include="settings-shared">
12 :host { 12 :host {
13 -webkit-margin-start: 36px; 13 -webkit-margin-start: 36px;
14 align-items: center; 14 align-items: center;
15 display: flex; 15 display: flex;
16 min-height: var(--settings-row-min-height); 16 min-height: var(--settings-row-min-height);
17 } 17 }
18 18
19 img { 19 img {
20 @apply(--cr-icon-height-width); 20 @apply(--cr-icon-height-width);
21 -webkit-margin-end: 16px; 21 -webkit-margin-end: 16px;
22 } 22 }
23 23
24 span { 24 /* Using ">" operator to ensure that this CSS rule will not accidentally
25 be applied to a search highlight span (which is inserted dynamically if
26 when search "hit" occurs within this element. */
dschuyler 2017/06/07 23:33:06 Nit: It seems common to start comment lines with
dpapad 2017/06/08 00:03:59 Done.
27 :host > span {
25 -webkit-margin-end: 8px; 28 -webkit-margin-end: 8px;
26 flex: 1; 29 flex: 1;
27 } 30 }
28 </style> 31 </style>
29 <img role="presentation" src="chrome://extension-icon/[[extensionId]]/40/1"> 32 <img role="presentation" src="chrome://extension-icon/[[extensionId]]/40/1">
30 <span inner-h-t-m-l="[[getLabel_(extensionId, extensionName)]]"></span> 33 <span inner-h-t-m-l="[[getLabel_(extensionId, extensionName)]]"></span>
31 <template is="dom-if" if="[[extensionCanBeDisabled]]" restamp> 34 <template is="dom-if" if="[[extensionCanBeDisabled]]" restamp>
32 <paper-button class="secondary-button" on-tap="onDisableTap_"> 35 <paper-button class="secondary-button" on-tap="onDisableTap_">
33 $i18n{disable} 36 $i18n{disable}
34 </paper-button> 37 </paper-button>
35 </template> 38 </template>
36 </template> 39 </template>
37 </dom-module> 40 </dom-module>
38 41
39 <script src="extension_controlled_indicator.js"></script> 42 <script src="extension_controlled_indicator.js"></script>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698