Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2929013002: Revert of Add crash keys about field trial shared memory errors. (Closed)

Created:
3 years, 6 months ago by Alexei Svitkine (slow)
Modified:
3 years, 6 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add crash keys about field trial shared memory errors. (patchset #3 id:140001 of https://codereview.chromium.org/2872503003/ ) Reason for revert: No crashes observed that this instrumentation was meant to help with. Reverting the change. Original issue's description: > Add crash keys about field trial shared memory errors. > > This is needed to figure out the cause of the failures in field > trial shared memory allocation & map operations. > > Adds crash keys for the error values when shared memory > APIs fail from field trial code, to diagnose the crash causes. > > The temporary logging CL adds coverage to Mac codepaths > specifically, since that is the issue being investigated. The > plan is to clean up the code once the crbug has been fixed. > > BUG=703649 > > Review-Url: https://codereview.chromium.org/2872503003 > Cr-Commit-Position: refs/heads/master@{#470802} > Committed: https://chromium.googlesource.com/chromium/src/+/0fe371d918bf4d467619c1cd2d9fd9f3ee117add TBR=erikchen@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=703649 Review-Url: https://codereview.chromium.org/2929013002 Cr-Commit-Position: refs/heads/master@{#478076} Committed: https://chromium.googlesource.com/chromium/src/+/c2f02c3631738dc1c4f630eaa430b96d03057123

Patch Set 1 #

Patch Set 2 : Rebase & fix conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -103 lines) Patch
M base/memory/shared_memory.h View 1 3 chunks +0 lines, -24 lines 0 comments Download
M base/memory/shared_memory_helper.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M base/memory/shared_memory_helper.cc View 1 5 chunks +6 lines, -15 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 4 chunks +9 lines, -25 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download
M base/metrics/field_trial.cc View 1 2 chunks +2 lines, -17 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Alexei Svitkine (slow)
Created Revert of Add crash keys about field trial shared memory errors.
3 years, 6 months ago (2017-06-08 17:32:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929013002/1
3 years, 6 months ago (2017-06-08 17:33:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/233622) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-08 17:36:09 UTC) #5
Alexei Svitkine (slow)
Rebased.
3 years, 6 months ago (2017-06-08 17:56:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929013002/170001
3 years, 6 months ago (2017-06-08 17:58:07 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 20:41:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/c2f02c3631738dc1c4f630eaa430...

Powered by Google App Engine
This is Rietveld 408576698