Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2929013002: Revert of Add crash keys about field trial shared memory errors. (Closed)
Patch Set: Rebase & fix conflicts. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/metrics/field_trial.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <windows.h> 9 #include <windows.h>
10 10
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 // Temporary for https://crbug.com/668633. 175 // Temporary for https://crbug.com/668633.
176 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize}, 176 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
177 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize}, 177 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
178 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize}, 178 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize},
179 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize}, 179 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize},
180 180
181 // Temporary for https://crbug.com/697745. 181 // Temporary for https://crbug.com/697745.
182 {"engine_params", crash_keys::kMediumSize}, 182 {"engine_params", crash_keys::kMediumSize},
183 {"engine1_params", crash_keys::kMediumSize}, 183 {"engine1_params", crash_keys::kMediumSize},
184 {"engine2_params", crash_keys::kMediumSize}, 184 {"engine2_params", crash_keys::kMediumSize},
185
186 // Temporary for http://crbug.com/703649.
187 {"field_trial_shmem_create_error", crash_keys::kSmallSize},
188 {"field_trial_shmem_map_error", crash_keys::kSmallSize},
189 }; 185 };
190 186
191 // This dynamic set of keys is used for sets of key value pairs when gathering 187 // This dynamic set of keys is used for sets of key value pairs when gathering
192 // a collection of data, like command line switches or extension IDs. 188 // a collection of data, like command line switches or extension IDs.
193 std::vector<base::debug::CrashKey> keys(std::begin(kFixedKeys), 189 std::vector<base::debug::CrashKey> keys(std::begin(kFixedKeys),
194 std::end(kFixedKeys)); 190 std::end(kFixedKeys));
195 191
196 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 192 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
197 193
198 // Register the extension IDs. 194 // Register the extension IDs.
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 410
415 return base::RandDouble() < probability; 411 return base::RandDouble() < probability;
416 } 412 }
417 413
418 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 414 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
419 const std::string& process_type) { 415 const std::string& process_type) {
420 // This is not used by Crashpad (at least on Windows). 416 // This is not used by Crashpad (at least on Windows).
421 NOTREACHED(); 417 NOTREACHED();
422 return true; 418 return true;
423 } 419 }
OLDNEW
« no previous file with comments | « base/metrics/field_trial.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698