Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2928933002: Fix 'Less than 1 MB' used inside a sentence (Closed)

Created:
3 years, 6 months ago by msramek
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Fix 'Less than 1 MB' used inside a sentence The string 'Less than 1 MB' is used inside a sentence in CBD. This is incorrect because of the upper case L. To fix this we reintroduce the "less than 1 MB" string. It is still in the translation console, so it shouldn't require translation. This CL doesn't fix the usage of 'Less than X MB' which is only used on desktop and the fact that this sentence insertion could go wrong due to sentence structure in other languages. BUG=729942 Review-Url: https://codereview.chromium.org/2921423002 Cr-Original-Commit-Position: refs/heads/master@{#477267} Review-Url: https://codereview.chromium.org/2928933002 . Cr-Commit-Position: refs/branch-heads/3112@{#248} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/10a2061f67a6ca24c511ed05339feae8bf57f6d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M chrome/browser/browsing_data/browsing_data_counter_utils.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M components/browsing_data_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
3 years, 6 months ago (2017-06-08 08:37:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10a2061f67a6ca24c511ed05339feae8bf57f6d5.

Powered by Google App Engine
This is Rietveld 408576698