Fix 'Less than 1 MB' used inside a sentence

Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used 
on desktop and the fact that this sentence insertion could go wrong 
due to  sentence structure in other languages. 

BUG=729942
Review-Url: https://codereview.chromium.org/2921423002
Cr-Commit-Position: refs/heads/master@{#477267}
Committed: https://chromium.googlesource.com/chromium/src/+/ee6a8849e41e7e43563e32b24f5d949c8c01f015

[dullweber, 2017-06-06 09:04:05]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 09:04:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-06 09:05:18]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org

[dullweber, 2017-06-06 09:05:19]

Hi Martin,
here is the fix for the cache string. Please take a look at it. I also added a
test because the cache string logic is already quite complex.

[commit-bot: I haz the power, 2017-06-06 09:54:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 09:54:11]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-06-06 09:57:41]

LGTM, thanks for adding a test.

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
(right):

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc:41: const
int MB = 1024 * 1024;
style nit: kNameConstantsLikeThis (ideally reuse the name "kBytesInAMegabyte"
from the other file).

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc:56: //
TODO(dullweber): Fix upper case L in estimate string for desktop.
I suggest including a bug number here, since this is not a "we could do this
better" kind of TODO, but rather a "we really need to fix this to proceed" kind.

[dullweber, 2017-06-06 11:26:54]

According to Max' suggestion I added a "less than 1 MB" string that is used
inside the sentence. 
https://www.chromium.org/developers/design-documents/ui-localization says that
"existing translations are reused when a new message matches an existing one"
and the translation console still shows the old string, so I hope it works.

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
(right):

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc:41: const
int MB = 1024 * 1024;
On 2017/06/06 09:57:41, msramek (slow) wrote:
> style nit: kNameConstantsLikeThis (ideally reuse the name "kBytesInAMegabyte"
> from the other file).

Done.

https://codereview.chromium.org/2921423002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc:56: //
TODO(dullweber): Fix upper case L in estimate string for desktop.
On 2017/06/06 09:57:40, msramek (slow) wrote:
> I suggest including a bug number here, since this is not a "we could do this
> better" kind of TODO, but rather a "we really need to fix this to proceed"
kind.

Done.

[dullweber, 2017-06-06 11:27:49]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 11:27:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-06-06 11:44:21]

Still LGTM. Please update the CL description to explain the current state
(including the fact that basic tab NAND upper estimate).

[dullweber, 2017-06-06 11:59:16]

Description was changed from

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L but could also be an issue
during translation. To fix this we only show 'Less than 1 MB' for small
caches because the impact of a deletion wouldn't be big.

BUG=729942
==========

to

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used on desktop
and the fact that this sentence insertion could go wrong due to 
the sentence structure in other languages. 

BUG=729942
==========

[dullweber, 2017-06-06 11:59:34]

Description was changed from

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used on desktop
and the fact that this sentence insertion could go wrong due to 
the sentence structure in other languages. 

BUG=729942
==========

to

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used 
on desktop and the fact that this sentence insertion could go wrong 
due to  sentence structure in other languages. 

BUG=729942
==========

[commit-bot: I haz the power, 2017-06-06 12:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 12:23:48]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-06-06 12:25:16]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-06-06 12:25:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 12:29:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496751916084760,
"parent_rev": "0ce8475aedc63ddc635d94aa2cebc7b8b07a40b3", "commit_rev":
"ee6a8849e41e7e43563e32b24f5d949c8c01f015"}

[commit-bot: I haz the power, 2017-06-06 12:29:37]

Description was changed from

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used 
on desktop and the fact that this sentence insertion could go wrong 
due to  sentence structure in other languages. 

BUG=729942
==========

to

==========
Fix 'Less than 1 MB' used inside a sentence

The string 'Less than 1 MB' is used inside a sentence in CBD.
This is incorrect because of the upper case L. 
To fix this we reintroduce the "less than 1 MB" string. It is still in 
the translation console, so it shouldn't require translation.

This CL doesn't fix the usage of 'Less than X MB' which is only used 
on desktop and the fact that this sentence insertion could go wrong 
due to  sentence structure in other languages. 

BUG=729942

Review-Url: https://codereview.chromium.org/2921423002
Cr-Commit-Position: refs/heads/master@{#477267}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a8849e41e7e43563e32b24f5d...
==========

[commit-bot: I haz the power, 2017-06-06 12:29:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee6a8849e41e7e43563e32b24f5d...