Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2928703006: chrome/android: Fix black flash on cold start. (Closed)

Created:
3 years, 6 months ago by Khushal
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

chrome/android: Fix black flash on cold start. We currently see a black flash on cold start with some pages because the logic uses the SwapBuffers notification to hide the background color on the View to make the underlying Surface visible. Since the SwapBuffers notification doesn't ensure that the rendering has finished, it may not actually be used by the SurfaceFlinger which causes a black flash. Since we have similar logic for the tab strip which is also drawn in native, merge this logic in one place and remove the background only after the second frame is drawn. BUG=729278 Review-Url: https://codereview.chromium.org/2926803003 Cr-Original-Commit-Position: refs/heads/master@{#477774} Review-Url: https://codereview.chromium.org/2928703006 . Cr-Commit-Position: refs/branch-heads/3112@{#244} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/d317f0434ffd4eacbe8f4f412da254a411cf34ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -32 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java View 4 chunks +0 lines, -28 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Khushal
3 years, 6 months ago (2017-06-08 01:22:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d317f0434ffd4eacbe8f4f412da254a411cf34ea.

Powered by Google App Engine
This is Rietveld 408576698