chrome/android: Fix black flash on cold start.

chrome/android: Fix black flash on cold start.

We currently see a black flash on cold start with some pages because
the logic uses the SwapBuffers notification to hide the background color
on the View to make the underlying Surface visible.

Since the SwapBuffers notification doesn't ensure that the rendering
has finished, it may not actually be used by the SurfaceFlinger which
causes a black flash.

Since we have similar logic for the tab strip which is also drawn in
native, merge this logic in one place and remove the background only
after the second frame is drawn.

BUG=729278
Review-Url: https://codereview.chromium.org/2926803003
Cr-Commit-Position: refs/heads/master@{#477774}
Committed: https://chromium.googlesource.com/chromium/src/+/481b7bd458ec703fbe99d111424a7a260658f185

[Khushal, 2017-06-07 07:22:45]

khushalsagar@chromium.org changed reviewers:
+ aelias@chromium.org, tedchoc@chromium.org

[Ted C, 2017-06-07 19:18:26]

lgtm

[aelias_OOO_until_Jul13, 2017-06-07 22:00:03]

Got it, it sounds like yusufo@'s fix for cold start black flash in
https://codereview.chromium.org/2271393003 was incomplete/racy, and you have
found a more complete fix.  lgtm

[Khushal, 2017-06-07 22:03:38]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2017-06-07 22:04:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 23:24:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496873018829680,
"parent_rev": "7f54a0cdff54d78585261561f6e64a910a41ef82", "commit_rev":
"481b7bd458ec703fbe99d111424a7a260658f185"}

[commit-bot: I haz the power, 2017-06-07 23:24:25]

Description was changed from

==========
chrome/android: Fix black flash on cold start.

We currently see a black flash on cold start with some pages because
the logic uses the SwapBuffers notification to hide the background color
on the View to make the underlying Surface visible.

Since the SwapBuffers notification doesn't ensure that the rendering
has finished, it may not actually be used by the SurfaceFlinger which
causes a black flash.

Since we have similar logic for the tab strip which is also drawn in
native, merge this logic in one place and remove the background only
after the second frame is drawn.

BUG=729278
==========

to

==========
chrome/android: Fix black flash on cold start.

We currently see a black flash on cold start with some pages because
the logic uses the SwapBuffers notification to hide the background color
on the View to make the underlying Surface visible.

Since the SwapBuffers notification doesn't ensure that the rendering
has finished, it may not actually be used by the SurfaceFlinger which
causes a black flash.

Since we have similar logic for the tab strip which is also drawn in
native, merge this logic in one place and remove the background only
after the second frame is drawn.

BUG=729278

Review-Url: https://codereview.chromium.org/2926803003
Cr-Commit-Position: refs/heads/master@{#477774}
Committed:
https://chromium.googlesource.com/chromium/src/+/481b7bd458ec703fbe99d111424a...
==========

[commit-bot: I haz the power, 2017-06-07 23:24:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/481b7bd458ec703fbe99d111424a...