Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2928433002: [CRD iOS] Use UINavigationController for view stack manipulation (Closed)

Created:
3 years, 6 months ago by Yuwei
Modified:
3 years, 6 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Use UINavigationController for view stack manipulation Previously we use modal popup for the host connection flow and we experienced UI churn when we dismiss the ClientConnectionView and open the HostView. The host list will flash onto the screen. This CL introduces a UINavigationController on the root level, which allows us to: * Replace the topmost view on the stack within one frame; no churn caused by the host list being rendered intermediately. * Get nice right-to-left and left-to-right transition effect for the host connection flow. Other calls to presentViewController are not affected. Review-Url: https://codereview.chromium.org/2928433002 Cr-Commit-Position: refs/heads/master@{#477095} Committed: https://chromium.googlesource.com/chromium/src/+/9acd0160c7449a806fa3a51bed5d2fb7aa9b350f

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M remoting/ios/app/app_delegate.mm View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/ios/app/client_connection_view_controller.mm View 1 2 chunks +7 lines, -10 lines 0 comments Download
M remoting/ios/app/host_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/app/remoting_view_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Yuwei
PTAL thanks! Note that this doesn't fix the green flash. It was caused by the ...
3 years, 6 months ago (2017-06-05 20:52:18 UTC) #4
nicholss
lgtm Nice work, the demo looked nice.
3 years, 6 months ago (2017-06-05 21:34:04 UTC) #5
Yuwei
Thanks! Checking-in :)
3 years, 6 months ago (2017-06-05 21:35:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928433002/20001
3 years, 6 months ago (2017-06-05 21:36:16 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 22:10:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9acd0160c7449a806fa3a51bed5d...

Powered by Google App Engine
This is Rietveld 408576698