[CRD iOS] Create RemotingClient in ClientConnectionViewController

[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues caused by the lingering RemotingClient.

Review-Url: https://codereview.chromium.org/2917253002
Cr-Commit-Position: refs/heads/master@{#477063}
Committed: https://chromium.googlesource.com/chromium/src/+/958a6ec35d7013b86aec0a7500547aff25eb8c4b

[Yuwei, 2017-06-05 06:36:08]

Description was changed from

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController
==========

to

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues like the lingering RemotingClient.
==========

[Yuwei, 2017-06-05 06:36:27]

Description was changed from

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues like the lingering RemotingClient.
==========

to

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues caused by the lingering RemotingClient.
==========

[Yuwei, 2017-06-05 06:36:42]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-06-05 06:36:42]

PTAL thanks!

[nicholss, 2017-06-05 18:24:13]

lgtm

https://codereview.chromium.org/2917253002/diff/20001/remoting/ios/app/client...
File remoting/ios/app/client_connection_view_controller.mm (right):

https://codereview.chromium.org/2917253002/diff/20001/remoting/ios/app/client...
remoting/ios/app/client_connection_view_controller.mm:305: [self
dismissViewControllerAnimated:YES
I think if you set this animated and the animated below to NO you can remove the
funky transitions for connecting.

[Yuwei, 2017-06-05 19:07:26]

Thanks!

https://codereview.chromium.org/2917253002/diff/20001/remoting/ios/app/client...
File remoting/ios/app/client_connection_view_controller.mm (right):

https://codereview.chromium.org/2917253002/diff/20001/remoting/ios/app/client...
remoting/ios/app/client_connection_view_controller.mm:305: [self
dismissViewControllerAnimated:YES
On 2017/06/05 18:24:13, nicholss wrote:
> I think if you set this animated and the animated below to NO you can remove
the
> funky transitions for connecting.

Done.

This does fix the transition but I still see a flash of the host list. I'm just
thinking could we just use a UINavigationController and remove the second stage
from the view stack here to prevent that churn...

[Yuwei, 2017-06-05 19:07:32]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-06-05 19:07:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2917253002/#ps40001
(title: "resolve feedback")

[commit-bot: I haz the power, 2017-06-05 19:07:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 19:30:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:30:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuwei, 2017-06-05 19:39:41]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:40:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 20:11:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496691581139010,
"parent_rev": "707b595f8a867a36db3ccb2c9f06f7e7ec1e58bf", "commit_rev":
"958a6ec35d7013b86aec0a7500547aff25eb8c4b"}

[commit-bot: I haz the power, 2017-06-05 20:11:27]

Description was changed from

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues caused by the lingering RemotingClient.
==========

to

==========
[CRD iOS] Create RemotingClient in ClientConnectionViewController

This CL moves the RemoteClient creation logic into the
ClientConnectionViewController and makes the Connection*Controller responsible
for creating the HostViewConnectionController.

This can streamline the creation flow of the view controllers and prevent
potential issues caused by the lingering RemotingClient.

Review-Url: https://codereview.chromium.org/2917253002
Cr-Commit-Position: refs/heads/master@{#477063}
Committed:
https://chromium.googlesource.com/chromium/src/+/958a6ec35d7013b86aec0a750054...
==========

[commit-bot: I haz the power, 2017-06-05 20:11:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/958a6ec35d7013b86aec0a750054...