Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2927943002: Revert of Adjust FreeType warning to avoid a Clang LLP64 build failure (Closed)

Created:
3 years, 6 months ago by drott
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adjust FreeType warning to avoid a Clang LLP64 build failure (patchset #1 id:1 of https://codereview.chromium.org/2781313002/ ) Reason for revert: Our FreeType should be rolled past this commit, let's try. Original issue's description: > Adjust FreeType warning to avoid a Clang LLP64 build failure > > For more details, see > https://savannah.nongnu.org/bugs/index.php?50560 > > TBR=bungeman@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2781313002 > Cr-Commit-Position: refs/heads/master@{#460693} > Committed: https://chromium.googlesource.com/chromium/src/+/7422d18f34593e58f21f7ff0eaa7420f1cc143d6 TBR=bungeman@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2927943002 Cr-Commit-Position: refs/heads/master@{#477983} Committed: https://chromium.googlesource.com/chromium/src/+/882d8c0d29354c71d2612590faccdbde64af41b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/freetype/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
drott
Created Revert of Adjust FreeType warning to avoid a Clang LLP64 build failure
3 years, 6 months ago (2017-06-08 14:03:31 UTC) #1
bungeman-chromium
So long as win_clang compiles, lgtm
3 years, 6 months ago (2017-06-08 14:34:28 UTC) #4
drott
3 years, 6 months ago (2017-06-08 15:39:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927943002/1
3 years, 6 months ago (2017-06-08 15:39:10 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 16:03:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/882d8c0d29354c71d2612590facc...

Powered by Google App Engine
This is Rietveld 408576698