Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2781313002: Adjust FreeType warning to avoid a Clang LLP64 build failure (Closed)

Created:
3 years, 8 months ago by drott
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust FreeType warning to avoid a Clang LLP64 build failure For more details, see https://savannah.nongnu.org/bugs/index.php?50560 TBR=bungeman@chromium.org BUG= Review-Url: https://codereview.chromium.org/2781313002 Cr-Commit-Position: refs/heads/master@{#460693} Committed: https://chromium.googlesource.com/chromium/src/+/7422d18f34593e58f21f7ff0eaa7420f1cc143d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/freetype/BUILD.gn View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781313002/1
3 years, 8 months ago (2017-03-30 07:20:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7422d18f34593e58f21f7ff0eaa7420f1cc143d6
3 years, 8 months ago (2017-03-30 08:22:15 UTC) #5
Lei Zhang
Safe to revert now?
3 years, 6 months ago (2017-06-08 05:42:34 UTC) #7
drott
3 years, 6 months ago (2017-06-08 14:03:31 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2927943002/ by drott@chromium.org.

The reason for reverting is: Our FreeType should be rolled past this commit,
let's try..

Powered by Google App Engine
This is Rietveld 408576698