Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2927883002: Explicitly setting story names for thread_times benchmarks (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, vmiura, tdresser, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly setting story names for thread_times benchmarks BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2927883002 Cr-Commit-Position: refs/heads/master@{#477820} Committed: https://chromium.googlesource.com/chromium/src/+/2b07f89b0ab15ff76a01ede77d347e90bdcc6582

Patch Set 1 #

Patch Set 2 : Explicitly setting story names for thread_times benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M tools/perf/page_sets/key_hit_test_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_idle_power_cases.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_noop_cases.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/simple_mobile_sites.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_scrolling_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ashleymarie1
3 years, 6 months ago (2017-06-07 19:50:33 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-07 20:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927883002/20001
3 years, 6 months ago (2017-06-07 20:32:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/429021)
3 years, 6 months ago (2017-06-07 21:14:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927883002/20001
3 years, 6 months ago (2017-06-07 23:04:47 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:16:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b07f89b0ab15ff76a01ede77d34...

Powered by Google App Engine
This is Rietveld 408576698