tools/perf/page_sets/key_noop_cases.py - Issue 2927883002: Explicitly setting story names for thread_times benchmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_noop_cases.py

Issue 2927883002: Explicitly setting story names for thread_times benchmarks (Closed)

Patch Set: Explicitly setting story names for thread_times benchmarks Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/key_noop_cases.py

diff --git a/tools/perf/page_sets/key_noop_cases.py b/tools/perf/page_sets/key_noop_cases.py

index 7175eca113d6ac6b3cc664911530ddb0ab6f5e32..a4639e45f2c9115297414df91defe9325c348175 100644

--- a/tools/perf/page_sets/key_noop_cases.py

+++ b/tools/perf/page_sets/key_noop_cases.py

@@ -12,7 +12,8 @@ class NoOpPage(page_module.Page):

super(NoOpPage, self).__init__(

url=url,

page_set=page_set,

- shared_page_state_class=shared_page_state.SharedMobilePageState)

+ shared_page_state_class=shared_page_state.SharedMobilePageState,

+ name=url.split('/')[-1])

def RunNavigateSteps(self, action_runner):

super(NoOpPage, self).RunNavigateSteps(action_runner)

@@ -41,7 +42,7 @@ class KeyNoOpCasesPageSet(story.StorySet):

""" Key no-op cases """

def __init__(self):

- super(KeyNoOpCasesPageSet, self).__init__()

+ super(KeyNoOpCasesPageSet, self).__init__(verify_names=True)

# Why: An infinite rAF loop which does not modify the page should incur

# minimal activity.