Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 292773002: Pass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion (Closed)

Created:
6 years, 7 months ago by egdaniel
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Pass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14790

Patch Set 1 : #

Patch Set 2 : Nit variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M include/gpu/SkGr.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 15 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/SkGr.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
egdaniel
ptal
6 years, 7 months ago (2014-05-19 18:40:14 UTC) #1
bsalomon
6 years, 7 months ago (2014-05-19 18:44:24 UTC) #2
bsalomon
On 2014/05/19 18:44:24, bsalomon wrote: lgtm
6 years, 7 months ago (2014-05-19 18:44:32 UTC) #3
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 7 months ago (2014-05-19 19:30:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/292773002/40001
6 years, 7 months ago (2014-05-19 19:30:28 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 19:36:03 UTC) #6
Message was sent while issue was closed.
Change committed as 14790

Powered by Google App Engine
This is Rietveld 408576698