Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2927703003: Move ObjectContentType entirely to HTMLPlugInElement (Closed)
Patch Set: More Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
index 9eb7fa5ed2166583ff368e1a36dc3fb31a4f5117..924973f5efd18dc4901be643b94e48bab447a69e 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
@@ -106,19 +106,10 @@ class CORE_EXPORT HTMLPlugInElement
virtual LayoutEmbeddedContent* LayoutEmbeddedContentForJSBindings() const;
bool IsImageType();
- bool ShouldPreferPlugInsForImages() const {
- return should_prefer_plug_ins_for_images_;
- }
LayoutEmbeddedItem GetLayoutEmbeddedItem() const;
bool AllowedToLoadFrameURL(const String& url);
- bool RequestObject(const String& url,
- const String& mime_type,
- const Vector<String>& param_names,
+ bool RequestObject(const Vector<String>& param_names,
const Vector<String>& param_values);
- bool ShouldUsePlugin(const KURL&,
- const String& mime_type,
- bool has_fallback,
- bool& use_fallback);
void DispatchErrorEvent();
bool IsErrorplaceholder();
@@ -173,13 +164,18 @@ class CORE_EXPORT HTMLPlugInElement
bool AllowedToLoadPlugin(const KURL&, const String& mime_type);
// Perform checks based on the URL and MIME-type of the object to load.
bool AllowedToLoadObject(const KURL&, const String& mime_type);
- bool WouldLoadAsNetscapePlugin(const String& url, const String& service_type);
+
+ enum class ObjectContentType {
+ kNone,
+ kImage,
+ kFrame,
+ kPlugin,
+ };
+ ObjectContentType GetObjectContentType();
void SetPersistedPlugin(PluginView*);
- bool RequestObjectInternal(const String& url,
- const String& mime_type,
- const Vector<String>& param_names,
+ bool RequestObjectInternal(const Vector<String>& param_names,
const Vector<String>& param_values);
v8::Global<v8::Object> plugin_wrapper_;

Powered by Google App Engine
This is Rietveld 408576698