Descriptionmash: Limit ShelfWindowWatcher to panels and dialogs.
Chrome now syncs its own ShelfModel with Ash in Mash.
Avoid ShelfWindowWatcher and ChromeLauncherController clashing.
(ie. don't create SWW items for windows that CLC will handle)
Set TYPE_APP for extension and arc app windows to avoid SWW items.
Set TYPE_APP_PANEL in extension code; simplify ChromeNativeAppWindowViewsAuraAsh.
Make SWW items for transient windows (per discussion w/oshima).
Only make SWW items for WINDOW_TYPE_NORMAL windows w/o a ShelfItemType.
(avoid making items for [transient] controls, popups, etc.)
Only make SWW items for visible windows (or minimized panels).
(clients set a ShelfItemType before Show() to avoid SWW items)
(fixes StatusAreaBubble, prior to WindowState::ignored_by_shelf)
Expand and refine ShelfWindowWatcher unit tests.
Fix simulated panel window creation in other unit tests.
Restore ExperimentalAppWindowApiTest.SetIcon to mash white lists.
Disable WindowSelectorTest.MultipleDisplays in mash for now.
TODO: Determine why OnAppWindowAdded is only called in Mash...
BUG=557406, 679087, 695562, 729425, 730759
TEST=Automated; chrome --mash doesn't crash opening the wallpaper picker.
R=sky@chromium.org
TBR=jamescook@chromium.org
Review-Url: https://codereview.chromium.org/2927693002
Cr-Commit-Position: refs/heads/master@{#477884}
Committed: https://chromium.googlesource.com/chromium/src/+/feae432eb3cfeafbd4c30795171ac46462a23c80
Patch Set 1 #Patch Set 2 : Restore ExperimentalAppWindowApiTest.SetIcon to mash browser test whitelists. #Patch Set 3 : Set the ShelfItemType for Arc app windows. #Patch Set 4 : Fix panel behavior, unit tests, etc. #
Total comments: 4
Patch Set 5 : Disable WindowSelectorTest.MultipleDisplays in mash. #
Total comments: 7
Messages
Total messages: 33 (23 generated)
|