Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2328)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 2927693002: mash: Limit ShelfWindowWatcher to panels and dialogs. (Closed)
Patch Set: Disable WindowSelectorTest.MultipleDisplays in mash. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index 1b68e02b6529b11b7a5192780c191a95b23a458a..e214736550ddde99b252300cf67a7155a5e6e83b 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -145,6 +145,7 @@ class WindowSelectorTest : public test::AshTestBase {
static int id = 0;
std::string shelf_id(ShelfID(base::IntToString(id++)).Serialize());
window->SetProperty(kShelfIDKey, new std::string(shelf_id));
+ window->SetProperty<int>(kShelfItemTypeKey, TYPE_APP_PANEL);
window->SetProperty(aura::client::kTopViewInset, kHeaderHeight);
shelf_view_test()->RunMessageLoopUntilAnimationsDone();
return window;
@@ -1142,6 +1143,10 @@ TEST_F(WindowSelectorTest, ClickModalWindowParent) {
// Tests that windows remain on the display they are currently on in overview
// mode, and that the close buttons are on matching displays.
TEST_F(WindowSelectorTest, MultipleDisplays) {
+ // TODO: Crashes in bounds_animator.cc in mash: http://crbug.com/730759
+ if (Shell::GetAshConfig() == Config::MASH)
+ return;
+
UpdateDisplay("600x400,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
gfx::Rect bounds1(0, 0, 400, 400);

Powered by Google App Engine
This is Rietveld 408576698