PlzNavigate: Remove TODO in NavigationRequest.

PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927023004
Cr-Commit-Position: refs/heads/master@{#478582}
Committed: https://chromium.googlesource.com/chromium/src/+/2e3e315ddecc6169fe53a44c30c82a2470f6050d

[arthursonzogni, 2017-06-09 13:43:24]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old and according to
what is stated in the heading comments of this function, no
history-navigation is expected to happens here. So the current value
(-1) should be correct and the TODO removed.
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old and according to
what is stated in the heading comments of this function, no
history-navigation is expected to happens here. So the current value
(-1) should be correct and the TODO removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[arthursonzogni, 2017-06-09 13:49:22]

Patchset #1 (id:1) has been deleted

[arthursonzogni, 2017-06-09 13:50:29]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old and according to
what is stated in the heading comments of this function, no
history-navigation is expected to happens here. So the current value
(-1) should be correct and the TODO removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) must be correct and the TODO removed.
==========

[arthursonzogni, 2017-06-09 13:51:16]

arthursonzogni@chromium.org changed reviewers:
+ nasko@chromium.org

[arthursonzogni, 2017-06-09 13:51:17]

Hi Nasko,

Could you please review this patch?

[arthursonzogni, 2017-06-09 13:52:05]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) must be correct and the TODO removed.
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is be correct and the TODO can be removed.
==========

[arthursonzogni, 2017-06-09 14:49:15]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is be correct and the TODO can be removed.
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
==========

[nasko, 2017-06-09 22:29:26]

LGTM with a nit.

https://codereview.chromium.org/2927023004/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigation_request.cc (right):

https://codereview.chromium.org/2927023004/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigation_request.cc:292: // history-navigations
doesn't use this path. See comments above.
nit: s/doesn't/do not/ or if you prefer "don't".

[arthursonzogni, 2017-06-12 08:21:06]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[arthursonzogni, 2017-06-12 08:23:01]

Thanks!

[arthursonzogni, 2017-06-12 08:23:09]

The CQ bit was checked by arthursonzogni@chromium.org

[arthursonzogni, 2017-06-12 08:23:10]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2927023004/#ps40001
(title: "Nit.")

[commit-bot: I haz the power, 2017-06-12 08:23:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 10:18:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497255789933900,
"parent_rev": "8148de4fd6ee28b93a6d2bd40bac79188cf590da", "commit_rev":
"2e3e315ddecc6169fe53a44c30c82a2470f6050d"}

[commit-bot: I haz the power, 2017-06-12 10:18:41]

Description was changed from

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: Remove TODO in NavigationRequest.

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927023004
Cr-Commit-Position: refs/heads/master@{#478582}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e3e315ddecc6169fe53a44c30c8...
==========

[commit-bot: I haz the power, 2017-06-12 10:18:42]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2e3e315ddecc6169fe53a44c30c8...