PlzNavigate: Remove TODO in NavigationRequest.

content/browser/frame_host/navigation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_request.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "content/browser/appcache/appcache_navigation_handle.h"
@@ skipping 259 matching lines @@
   //   are initiated by a javascript script, please see the IPC message
   //   ViewHostMsg_GoToEntryAtOffset.
   DCHECK(FrameMsg_Navigate_Type::IsReload(common_params.navigation_type) ||
          common_params.navigation_type ==
              FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT);
 
   // TODO(clamy): See how we should handle override of the user agent when the
   // navigation may start in a renderer and commit in another one.
   // TODO(clamy): See if the navigation start time should be measured in the
   // renderer and sent to the browser instead of being measured here.
-  // TODO(clamy): The pending history list offset should be properly set.
   RequestNavigationParams request_params(
       false,                // is_overriding_user_agent
       std::vector<GURL>(),  // redirects
       common_params.url, common_params.method,
       false,                          // can_load_local_resources
       PageState(),                    // page_state
       0,                              // nav_entry_id
       false,                          // is_history_navigation_in_new_child
       std::map<std::string, bool>(),  // subframe_unique_names
       frame_tree_node->has_committed_real_load(),
       false,  // intended_as_new_entry
-      -1,     // pending_history_list_offset
+      -1,     // |pending_history_list_offset| is set to -1 because
+              // history-navigations doesn't use this path. See comments above.

[nasko, 2017/06/09 22:29:24]

nit: s/doesn't/do not/ or if you prefer "don't".

       current_history_list_offset, current_history_list_length,
       false,  // is_view_source
       false,  // should_clear_history_list
       begin_params.has_user_gesture);
   std::unique_ptr<NavigationRequest> navigation_request(new NavigationRequest(
       frame_tree_node, common_params, begin_params, request_params,
       false,  // browser_initiated
       false,  // may_transfer
       nullptr, entry));
   return navigation_request;
@@ skipping 643 matching lines @@
   if (parent->IsAllowedByCsp(
           CSPDirective::FrameSrc, common_params_.url, is_redirect,
           common_params_.source_location.value_or(SourceLocation()))) {
     return CONTENT_SECURITY_POLICY_CHECK_PASSED;
   }
 
   return CONTENT_SECURITY_POLICY_CHECK_FAILED;
 }
 
 }  // namespace content