Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2926743002: Make empty sign-in banner hidden to avoid blocking user removal button (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make empty sign-in banner hidden to avoid blocking user removal button 1) 'Remove user' button may be blocked by a transparent sign-in banner and becomes unclickable, so hide the banner if it's empty. Also adjust the z-index of the button to be the same with the user menu. 2) Minor change on the positioning of the user menu area. BUG=730155 Review-Url: https://codereview.chromium.org/2926743002 Cr-Commit-Position: refs/heads/master@{#477708} Committed: https://chromium.googlesource.com/chromium/src/+/1e531eb4ecf2fbf80ce97b92e00de76f46969c8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/login/account_picker/md_user_pod_row.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/login/account_picker/md_user_pod_template.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-06 22:38:41 UTC) #3
jdufault
lgtm
3 years, 6 months ago (2017-06-07 17:22:06 UTC) #4
xiyuan
lgtm
3 years, 6 months ago (2017-06-07 17:40:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926743002/1
3 years, 6 months ago (2017-06-07 17:56:08 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 18:13:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e531eb4ecf2fbf80ce97b92e00d...

Powered by Google App Engine
This is Rietveld 408576698