Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: ui/login/account_picker/md_user_pod_row.js

Issue 2926743002: Make empty sign-in banner hidden to avoid blocking user removal button (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/login/account_picker/md_user_pod_row.css ('k') | ui/login/account_picker/md_user_pod_template.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/md_user_pod_row.js
diff --git a/ui/login/account_picker/md_user_pod_row.js b/ui/login/account_picker/md_user_pod_row.js
index e63775456ee15b536c54438c71deea3cf07eb3f4..6338b8ab42475905301eb106f7f2df6a7d37d61a 100644
--- a/ui/login/account_picker/md_user_pod_row.js
+++ b/ui/login/account_picker/md_user_pod_row.js
@@ -3866,9 +3866,8 @@ cr.define('login', function() {
// elements outside the pod.
var actionBoxMenu = pod.querySelector('.action-box-menu');
var actionBoxButton = pod.querySelector('.action-box-button');
- var MENU_TOP_PADDING = 7;
actionBoxMenu.style.top =
- cr.ui.toCssPx(actionBoxButton.offsetHeight + MENU_TOP_PADDING);
+ cr.ui.toCssPx(actionBoxButton.offsetHeight);
if (this.isPortraitMode_() && pods.length > 1) {
// Confine the menu inside the pod when it may overlap with outside
// elements.
@@ -3986,6 +3985,7 @@ cr.define('login', function() {
var banner = $('signin-banner');
banner.textContent = message;
banner.classList.toggle('message-set', !!message);
+ $('signin-banner-container1').hidden = banner.textContent.length == 0;
},
/**
« no previous file with comments | « ui/login/account_picker/md_user_pod_row.css ('k') | ui/login/account_picker/md_user_pod_template.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698