Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2926713004: Add support for repeated keys in TaskRequest. (Closed)

Created:
3 years, 6 months ago by M-A Ruel
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add support for repeated keys in TaskRequest. - Causes all properties_hash to change, so task deduplication is temporarily affected. - While the internals changed, task_queues.hash_dimensions() is unaffected, so the task queues will continue working as before. - Most of the changes are in unit tests due to the way dimensions specification changed. - One local smoke test was updated to specify duplicate key to confirm it works end-to-end. - Explicitly deny ':' in key for request earlier in the pipeline due to the internal encoding. It makes sense because this is also how tags are encoded. - This change is only backward compatible up to the gap commit. R=vadimsh@chromium.org BUG=728124

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -272 lines) Patch
M appengine/swarming/doc/Schemas.md View 1 chunk +3 lines, -2 lines 0 comments Download
M appengine/swarming/event_mon_metrics.py View 3 chunks +17 lines, -18 lines 0 comments Download
M appengine/swarming/handlers_bot_test.py View 5 chunks +20 lines, -20 lines 0 comments Download
M appengine/swarming/local_smoke_test.py View 2 chunks +18 lines, -2 lines 0 comments Download
M appengine/swarming/message_conversion.py View 4 chunks +14 lines, -7 lines 0 comments Download
M appengine/swarming/server/task_queues.py View 5 chunks +29 lines, -13 lines 0 comments Download
M appengine/swarming/server/task_queues_test.py View 3 chunks +8 lines, -9 lines 0 comments Download
M appengine/swarming/server/task_request.py View 7 chunks +17 lines, -11 lines 0 comments Download
M appengine/swarming/server/task_request_test.py View 10 chunks +44 lines, -32 lines 0 comments Download
M appengine/swarming/server/task_result_test.py View 1 chunk +1 line, -2 lines 0 comments Download
M appengine/swarming/server/task_scheduler.py View 1 chunk +4 lines, -3 lines 0 comments Download
M appengine/swarming/server/task_scheduler_test.py View 32 chunks +47 lines, -56 lines 0 comments Download
M appengine/swarming/server/task_to_run.py View 1 chunk +10 lines, -10 lines 0 comments Download
M appengine/swarming/server/task_to_run_test.py View 17 chunks +104 lines, -87 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (5 generated)
M-A Ruel
3 years, 6 months ago (2017-06-07 21:18:48 UTC) #6
I plan to deploy https://codereview.chromium.org/2928823002 first everywhere so
if any issue come up, reverting should be easy (unless I made an error).

In practice this change doesn't concerns me since it's fairly simple but I
prefer to take precaution, hence the previous CL.

Powered by Google App Engine
This is Rietveld 408576698