Add support for repeated keys in TaskRequest.

appengine/swarming/local_smoke_test.py

 #!/usr/bin/env python
 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Integration test for the Swarming server, Swarming bot and Swarming client.
 
 It starts both a Swarming server and a Swarming bot and triggers tasks with the
 Swarming client to ensure the system works end to end.
 """
@@ skipping 321 matching lines @@
         self.assertNotIn(u'caches', dimensions)
         break
 
   def gen_expected(self, **kwargs):
     return gen_expected(bot_dimensions=self.dimensions, **kwargs)
 
   def test_raw_bytes(self):
     # A string of a letter 'A', UTF-8 BOM then UTF-16 BOM then UTF-EDBCDIC then
     # invalid UTF-8 and the letter 'B'. It is double escaped so it can be passed
     # down the shell.
+    #
+    # Also confirm that a bot can run with multiple keys. Assume there's at
+    # least 2 'os' values.
     invalid_bytes = 'A\\xEF\\xBB\\xBF\\xFE\\xFF\\xDD\\x73\\x66\\x73\\xc3\\x28B'
     args = [
+      '--dimension', 'os', self.dimensions[u'os'][0],
+      '--dimension', 'os', self.dimensions[u'os'][1],
       '-T', 'non_utf8', '--',
       'python', '-u', '-c', 'print(\'' + invalid_bytes + '\')',
     ]
+    tags = [
+      u'os:%s' % self.dimensions[u'os'][0],
+      u'os:%s' % self.dimensions[u'os'][1],
+      u'pool:default',
+      u'priority:100',
+      u'service_account:none',
+      u'user:joe@localhost',
+    ]
     summary = self.gen_expected(
         name=u'non_utf8',
         # The string is mostly converted to 'Replacement Character'.
-        outputs=[u'A\ufeff\ufffd\ufffd\ufffdsfs\ufffd(B\n'])
+        outputs=[u'A\ufeff\ufffd\ufffd\ufffdsfs\ufffd(B\n'],
+        tags=tags)
     self.assertOneTask(args, summary, {})
 
   def test_invalid_command(self):
     args = ['-T', 'invalid', '--', 'unknown_invalid_command']
     summary = self.gen_expected(
         name=u'invalid',
         exit_codes=[1],
         failure=True,
         outputs=re.compile(
             u'^<The executable does not exist or a dependent library is '
@@ skipping 245 matching lines @@
           u'initial_number_items': u'0',
           u'initial_size': u'0',
           u'items_cold': sorted([len(hello_world), 199]),
           u'items_hot': [],
         },
         u'isolated_upload': {
           u'items_cold': [],
           u'items_hot': [],
         },
       },
+      # Intentionally hardcode the hash here to confirm consistency in the
+      # hashing mechanism.
       properties_hash =
-          u'082928de84d0a65839d227dcea2f5a947898929c77c1602b68c46d7d4588c1f5',
+          u'7340823890f29ffa64f81448517c541ebf4fc7b9ce5541bab05f3edda0cadafe',
     )
     task_id = self._run_isolated(
         hello_world, 'idempotent_reuse', ['--idempotent'], expected_summary, {})
     expected_summary[u'costs_usd'] = None
     expected_summary.pop('performance_stats')
     expected_summary[u'cost_saved_usd'] = 0.02
     expected_summary[u'deduped_from'] = task_id[:-1] + '1'
     expected_summary[u'try_number'] = 0
     expected_summary[u'properties_hash'] = None
     self._run_isolated(
@@ skipping 296 matching lines @@
     if bot is not None and bot.poll() is None:
       bot.kill()
       bot.wait()
   finally:
     cleanup(bot, client, servers, failed or verbose, leak)
   return int(failed)
 
 
 if __name__ == '__main__':
   sys.exit(main())