Remove VectorIconId references from the codebase

Remove VectorIconId references from the codebase

The VectorIconId enum is no longer used (deprecated
in favor of gfx::VectorIcon), so remove all dead
code and references to it.

BUG=720575
Review-Url: https://codereview.chromium.org/2926703002
Cr-Commit-Position: refs/heads/master@{#478423}
Committed: https://chromium.googlesource.com/chromium/src/+/d786ccd28e55ea6c23f54c4c22583d03f5d47d37

[tdanderson, 2017-06-06 21:17:56]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 21:18:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-06-06 21:18:50]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org

[tdanderson, 2017-06-06 21:18:50]

Evan, can you please take a look?

[Evan Stade, 2017-06-06 21:28:57]

lgtm, thanks

https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
File ash/system/palette/palette_tool_manager.h (right):

https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tool_manager.h:85: // Fetch the active tray icon for
the given tool. Returns gfx::kNoneIcon if
nit: returns an empty icon (not necessarily kNoneIcon but is_empty() should be
true)

https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
File components/toolbar/toolbar_model_delegate.h (right):

https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model_delegate.h:54: // gfx::kNoneIcon if the icon
should be selected by the caller. This is useful
are you sure it doesn't return null?

[commit-bot: I haz the power, 2017-06-06 22:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:50:36]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-06-07 15:55:09]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 15:55:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-06-07 15:55:54]

tdanderson@chromium.org changed reviewers:
+ pkasting@chromium.org

[tdanderson, 2017-06-07 15:55:55]

Peter, can you please take a look at components/ ?

Note: I will be updating the public-facing documentation once this lands.

https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
File ash/system/palette/palette_tool_manager.h (right):

https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tool_manager.h:85: // Fetch the active tray icon for
the given tool. Returns gfx::kNoneIcon if
On 2017/06/06 21:28:57, Evan Stade wrote:
> nit: returns an empty icon (not necessarily kNoneIcon but is_empty() should be
> true)

Done.

https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
File components/toolbar/toolbar_model_delegate.h (right):

https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model_delegate.h:54: // gfx::kNoneIcon if the icon
should be selected by the caller. This is useful
On 2017/06/06 21:28:57, Evan Stade wrote:
> are you sure it doesn't return null?

Done.

[commit-bot: I haz the power, 2017-06-07 17:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 17:21:44]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-06-09 17:51:14]

On 2017/06/07 15:55:55, tdanderson wrote:
> Peter, can you please take a look at components/ ?
> 
> Note: I will be updating the public-facing documentation once this lands.
> 
>
https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
> File ash/system/palette/palette_tool_manager.h (right):
> 
>
https://codereview.chromium.org/2926703002/diff/1/ash/system/palette/palette_...
> ash/system/palette/palette_tool_manager.h:85: // Fetch the active tray icon
for
> the given tool. Returns gfx::kNoneIcon if
> On 2017/06/06 21:28:57, Evan Stade wrote:
> > nit: returns an empty icon (not necessarily kNoneIcon but is_empty() should
be
> > true)
> 
> Done.
> 
>
https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
> File components/toolbar/toolbar_model_delegate.h (right):
> 
>
https://codereview.chromium.org/2926703002/diff/1/components/toolbar/toolbar_...
> components/toolbar/toolbar_model_delegate.h:54: // gfx::kNoneIcon if the icon
> should be selected by the caller. This is useful
> On 2017/06/06 21:28:57, Evan Stade wrote:
> > are you sure it doesn't return null?
> 
> Done.

pkasting@, friendly ping.

[Peter Kasting, 2017-06-09 19:50:29]

components/ LGTM

Sorry for the slow reply, was basically OOO the last two days.

[tdanderson, 2017-06-09 20:09:43]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2017-06-09 20:09:44]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2926703002/#ps20001
(title: "estade comments")

[commit-bot: I haz the power, 2017-06-09 20:10:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 21:28:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497038983921920,
"parent_rev": "07a679d47bcc3c003365e350a45094a68ba011fc", "commit_rev":
"d786ccd28e55ea6c23f54c4c22583d03f5d47d37"}

[commit-bot: I haz the power, 2017-06-09 21:28:52]

Description was changed from

==========
Remove VectorIconId references from the codebase

The VectorIconId enum is no longer used (deprecated
in favor of gfx::VectorIcon), so remove all dead
code and references to it.

BUG=720575
==========

to

==========
Remove VectorIconId references from the codebase

The VectorIconId enum is no longer used (deprecated
in favor of gfx::VectorIcon), so remove all dead
code and references to it.

BUG=720575

Review-Url: https://codereview.chromium.org/2926703002
Cr-Commit-Position: refs/heads/master@{#478423}
Committed:
https://chromium.googlesource.com/chromium/src/+/d786ccd28e55ea6c23f54c4c2258...
==========

[commit-bot: I haz the power, 2017-06-09 21:28:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d786ccd28e55ea6c23f54c4c2258...