Remove trailing semicolon at the end of a method definition

Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926553004
Cr-Commit-Position: refs/heads/master@{#478199}
Committed: https://chromium.googlesource.com/chromium/src/+/1ee189bd85e14ad9bedca7946d43b5054fe760af

[juncai, 2017-06-07 18:28:20]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[juncai, 2017-06-07 18:28:22]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[juncai, 2017-06-07 18:28:25]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[juncai, 2017-06-07 18:28:37]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:29:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-06-07 18:31:23]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master
.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryse
rver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chrom
ium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_
chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_test
s_rel
==========

[juncai, 2017-06-07 18:32:01]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master
.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryse
rver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chrom
ium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_
chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_test
s_rel
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[juncai, 2017-06-07 19:10:10]

juncai@chromium.org changed reviewers:
+ blundell@chromium.org, danakj@chromium.org, dcheng@chromium.org,
dgozman@chromium.org, haraken@chromium.org, jamescook@chromium.org,
jschuh@chromium.org, lazyboy@chromium.org, sadrul@chromium.org,
sdefresne@chromium.org, sergeyu@chromium.org, thestig@chromium.org,
xhwang@chromium.org, xunjieli@chromium.org

[juncai, 2017-06-07 19:10:11]

lazyboy@chromium.org: Please review changes in 
//extensions/

xhwang@chromium.org: Please review changes in 
//media/

sergeyu@chromium.org: Please review changes in 
//remoting/

jschuh@chromium.org: Please review changes in 
//sandbox/

jamescook@chromium.org: Please review changes in 
//ash/

dcheng@chromium.org: Please review changes in 
//base/
//third_party/WebKit/Source/core/

xunjieli@chromium.org: Please review changes in 
//net/

danakj@chromium.org: Please review changes in 
//cc/

sadrul@chromium.org: Please review changes in 
//ui/

haraken@chromium.org: Please review changes in 
//third_party/WebKit/Source/platform/

blundell@chromium.org: Please review changes in 
//components/

dgozman@chromium.org: Please review changes in 
//content/

thestig@chromium.org: Please review changes in 
//chrome/

sdefresne@chromium.org: Please review changes in 
//ios/

[danakj, 2017-06-07 19:11:09]

base and cc LGTM

[dgozman, 2017-06-07 19:14:57]

I don't know why these semicolons are bad and justify a separate patch with 15
reviewers, but since I've already looked at it - lgtm.

[lazyboy, 2017-06-07 19:15:42]

extension/browser/* and chrome/browser/extensions/* lgtm.

[Sergey Ulanov, 2017-06-07 19:20:30]

lgtm

[Sergey Ulanov, 2017-06-07 19:20:34]

lgtm

lgtm

[sdefresne, 2017-06-07 19:30:52]

ios/ lgtm

[dcheng, 2017-06-07 19:47:18]

base and third_party/WebKit/Source/core lgtm

[xunjieli, 2017-06-07 19:53:55]

On 2017/06/07 19:47:18, dcheng wrote:
> base and third_party/WebKit/Source/core lgtm

net/ LGTM

[Lei Zhang, 2017-06-07 20:15:06]

lgtm

[xhwang, 2017-06-07 20:23:51]

It might make sense to find one style reviewer, and TBR others.

Also, does it make sense to add a presubmit check to prevent this from happening
again?

media lgtm

[commit-bot: I haz the power, 2017-06-07 20:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 20:26:19]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[James Cook, 2017-06-07 20:45:10]

lgtm

[jschuh, 2017-06-07 20:51:29]

sandbox lgtm

[juncai, 2017-06-07 23:16:06]

On 2017/06/07 20:23:51, xhwang wrote:
> It might make sense to find one style reviewer, and TBR others.
> 
> Also, does it make sense to add a presubmit check to prevent this from
happening
> again?
> 
> media lgtm

Thanks for the suggestion.

Before I created this CL, I posted a question on the chromium-dev at:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/8D7Z7UP3reA
about adding some checks for this.

[haraken, 2017-06-07 23:40:53]

WebKit LGTM

[blundell, 2017-06-08 15:19:32]

//components lgtm

As someone else said, in the future I would either get a global owner for a
change like this or shard it into multiple CLs.

[sadrul, 2017-06-08 20:34:44]

lgtm

[juncai, 2017-06-08 20:46:47]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:47:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 20:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:52:45]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2017-06-08 21:24:09]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 21:24:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-06-08 21:25:55]

On 2017/06/08 15:19:32, blundell wrote:
> //components lgtm
> 
> As someone else said, in the future I would either get a global owner for a
> change like this or shard it into multiple CLs.

Sure. Thanks for the comments.

[Lei Zhang, 2017-06-08 21:41:38]

On 2017/06/08 15:19:32, blundell wrote:
> //components lgtm
> 
> As someone else said, in the future I would either get a global owner for a
> change like this or shard it into multiple CLs.

My vote is for splitting since each shard has no dependency on any other piece.
We even has "git cl split" now but I haven't tried it out yet.

[commit-bot: I haz the power, 2017-06-09 00:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 00:29:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[juncai, 2017-06-09 00:35:31]

The CQ bit was checked by juncai@chromium.org

[juncai, 2017-06-09 00:35:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sadrul@chromium.org, sergeyu@chromium.org,
xhwang@chromium.org, jschuh@chromium.org, dcheng@chromium.org,
xunjieli@chromium.org, danakj@chromium.org, thestig@chromium.org,
lazyboy@chromium.org, sdefresne@chromium.org, haraken@chromium.org,
dgozman@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2926553004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-09 00:36:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 03:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 03:10:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[juncai, 2017-06-09 03:29:41]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2017-06-09 03:29:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 04:25:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496978981822270,
"parent_rev": "61479a32e7d392656f32688a4dc733b3e19a87cc", "commit_rev":
"1ee189bd85e14ad9bedca7946d43b5054fe760af"}

[commit-bot: I haz the power, 2017-06-09 04:26:00]

Description was changed from

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove trailing semicolon at the end of a method definition

This CL removes extra trailing semicolon at the end of a method
definition.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926553004
Cr-Commit-Position: refs/heads/master@{#478199}
Committed:
https://chromium.googlesource.com/chromium/src/+/1ee189bd85e14ad9bedca7946d43...
==========

[commit-bot: I haz the power, 2017-06-09 04:26:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1ee189bd85e14ad9bedca7946d43...