Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

Issue 2926553004: Remove trailing semicolon at the end of a method definition (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/image_fetcher/core/image_fetcher_impl.h" 5 #include "components/image_fetcher/core/image_fetcher_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 24 matching lines...) Expand all
35 const char kInvalidImagePath[] = "/DOESNOTEXIST"; 35 const char kInvalidImagePath[] = "/DOESNOTEXIST";
36 36
37 const base::FilePath::CharType kDocRoot[] = 37 const base::FilePath::CharType kDocRoot[] =
38 FILE_PATH_LITERAL("chrome/test/data"); 38 FILE_PATH_LITERAL("chrome/test/data");
39 39
40 class TestImageFetcherDelegate : public ImageFetcherDelegate { 40 class TestImageFetcherDelegate : public ImageFetcherDelegate {
41 public: 41 public:
42 TestImageFetcherDelegate() 42 TestImageFetcherDelegate()
43 : num_delegate_valid_called_(0), 43 : num_delegate_valid_called_(0),
44 num_delegate_null_called_(0) {} 44 num_delegate_null_called_(0) {}
45 ~TestImageFetcherDelegate() override{}; 45 ~TestImageFetcherDelegate() override {}
46 46
47 // Perform additional tasks when an image has been fetched. 47 // Perform additional tasks when an image has been fetched.
48 void OnImageFetched(const std::string& id, const gfx::Image& image) override { 48 void OnImageFetched(const std::string& id, const gfx::Image& image) override {
49 if (!image.IsEmpty()) { 49 if (!image.IsEmpty()) {
50 num_delegate_valid_called_++; 50 num_delegate_valid_called_++;
51 } else { 51 } else {
52 num_delegate_null_called_++; 52 num_delegate_null_called_++;
53 } 53 }
54 }; 54 };
55 55
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec()); 143 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec());
144 StartOrQueueNetworkRequestHelper(invalid_image_url); 144 StartOrQueueNetworkRequestHelper(invalid_image_url);
145 145
146 EXPECT_EQ(0, num_callback_valid_called_); 146 EXPECT_EQ(0, num_callback_valid_called_);
147 EXPECT_EQ(1, num_callback_null_called_); 147 EXPECT_EQ(1, num_callback_null_called_);
148 EXPECT_EQ(0, delegate_.num_delegate_valid_called()); 148 EXPECT_EQ(0, delegate_.num_delegate_valid_called());
149 EXPECT_EQ(1, delegate_.num_delegate_null_called()); 149 EXPECT_EQ(1, delegate_.num_delegate_null_called());
150 } 150 }
151 151
152 } // namespace suggestions 152 } // namespace suggestions
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager_unittest.cc ('k') | chrome/browser/ssl/security_state_tab_helper_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698