Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2926533003: Revert of [inspector] Test how Profiler interacts with multiple sessions (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] Test how Profiler interacts with multiple sessions (patchset #3 id:30001 of https://codereview.chromium.org/2920313002/ ) Reason for revert: DCHECKS triggering in debug build. Original issue's description: > [inspector] Test how Profiler interacts with multiple sessions > > BUG=chromium:590878 > > Review-Url: https://codereview.chromium.org/2920313002 > Cr-Original-Commit-Position: refs/heads/master@{#45715} > Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6 > Review-Url: https://codereview.chromium.org/2920313002 > Cr-Commit-Position: refs/heads/master@{#45717} > Committed: https://chromium.googlesource.com/v8/v8/+/679604bdd2991a19cadf7ab5c462fc6f368f32fc TBR=alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2926533003 Cr-Commit-Position: refs/heads/master@{#45736} Committed: https://chromium.googlesource.com/v8/v8/+/0532e964980b3cc72e2e4c2ba066125e2fe6d217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -71 lines) Patch
D test/inspector/sessions/cpu-profile.js View 1 chunk +0 lines, -54 lines 0 comments Download
D test/inspector/sessions/cpu-profile-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dgozman
Created Revert of [inspector] Test how Profiler interacts with multiple sessions
3 years, 6 months ago (2017-06-06 15:43:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926533003/1
3 years, 6 months ago (2017-06-06 15:43:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 15:43:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0532e964980b3cc72e2e4c2ba066125e2fe...

Powered by Google App Engine
This is Rietveld 408576698