Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2926383003: Use ContainsValue() instead of std::find() in ui/aura, ui/display and ui/events (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
Reviewers:
a.suchit, sadrul, sadrul-g
CC:
chromium-reviews, kalyank, robliao+watch_chromium.org, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in ui/aura, ui/display and ui/events BUG=561800 Review-Url: https://codereview.chromium.org/2926383003 Cr-Commit-Position: refs/heads/master@{#478551} Committed: https://chromium.googlesource.com/chromium/src/+/4d256c3a2f663b2f94d865f7bf93f84db10ea328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M ui/aura/window.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/display/manager/display_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/manager/managed_display_info.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/display/win/screen_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/event_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tripta
Please review the code changes. Regards Tripta
3 years, 6 months ago (2017-06-09 10:14:46 UTC) #4
sadrul
lgtm
3 years, 6 months ago (2017-06-12 02:01:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926383003/1
3 years, 6 months ago (2017-06-12 03:16:49 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 04:14:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d256c3a2f663b2f94d865f7bf93...

Powered by Google App Engine
This is Rietveld 408576698