Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: ui/events/event_source.cc

Issue 2926383003: Use ContainsValue() instead of std::find() in ui/aura, ui/display and ui/events (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/display/win/screen_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/event_source.h" 5 #include "ui/events/event_source.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/stl_util.h"
9 #include "ui/events/event_rewriter.h" 10 #include "ui/events/event_rewriter.h"
10 #include "ui/events/event_sink.h" 11 #include "ui/events/event_sink.h"
11 12
12 namespace ui { 13 namespace ui {
13 14
14 EventSource::EventSource() {} 15 EventSource::EventSource() {}
15 16
16 EventSource::~EventSource() {} 17 EventSource::~EventSource() {}
17 18
18 void EventSource::AddEventRewriter(EventRewriter* rewriter) { 19 void EventSource::AddEventRewriter(EventRewriter* rewriter) {
19 DCHECK(rewriter); 20 DCHECK(rewriter);
20 DCHECK(rewriter_list_.end() == 21 DCHECK(!base::ContainsValue(rewriter_list_, rewriter));
21 std::find(rewriter_list_.begin(), rewriter_list_.end(), rewriter));
22 rewriter_list_.push_back(rewriter); 22 rewriter_list_.push_back(rewriter);
23 } 23 }
24 24
25 void EventSource::RemoveEventRewriter(EventRewriter* rewriter) { 25 void EventSource::RemoveEventRewriter(EventRewriter* rewriter) {
26 EventRewriterList::iterator find = 26 EventRewriterList::iterator find =
27 std::find(rewriter_list_.begin(), rewriter_list_.end(), rewriter); 27 std::find(rewriter_list_.begin(), rewriter_list_.end(), rewriter);
28 if (find != rewriter_list_.end()) 28 if (find != rewriter_list_.end())
29 rewriter_list_.erase(find); 29 rewriter_list_.erase(find);
30 } 30 }
31 31
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 return EventDispatchDetails(); 67 return EventDispatchDetails();
68 } 68 }
69 69
70 EventDispatchDetails EventSource::DeliverEventToSink(Event* event) { 70 EventDispatchDetails EventSource::DeliverEventToSink(Event* event) {
71 EventSink* sink = GetEventSink(); 71 EventSink* sink = GetEventSink();
72 CHECK(sink); 72 CHECK(sink);
73 return sink->OnEventFromSource(event); 73 return sink->OnEventFromSource(event);
74 } 74 }
75 75
76 } // namespace ui 76 } // namespace ui
OLDNEW
« no previous file with comments | « ui/display/win/screen_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698