Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2926303002: Settings reset prompt: Fetch default settings only when needed. (Closed)

Created:
3 years, 6 months ago by csharp
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Settings reset prompt: Fetch default settings only when needed. Instead of fetching the default settings when we create the SettingsResetPromptModel object, which is some time after startup, we now fetch settings only if the settings reset dialog needs to be shown to the user. BUG=727829 Review-Url: https://codereview.chromium.org/2918053003 Cr-Original-Commit-Position: refs/heads/master@{#477019} Review-Url: https://codereview.chromium.org/2926303002 . Cr-Commit-Position: refs/branch-heads/3112@{#258} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/556e3961add350236cfb50abbe394d5959ece352

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
csharp
3 years, 6 months ago (2017-06-08 18:00:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
556e3961add350236cfb50abbe394d5959ece352.

Powered by Google App Engine
This is Rietveld 408576698