Settings reset prompt: Fetch default settings only when needed.

Settings reset prompt: Fetch default settings only when needed.

Instead of fetching the default settings when we create the
SettingsResetPromptModel object, which is some time after startup, we
now fetch settings only if the settings reset dialog needs to be shown
to the user.

BUG=727829
Review-Url: https://codereview.chromium.org/2918053003
Cr-Commit-Position: refs/heads/master@{#477019}
Committed: https://chromium.googlesource.com/chromium/src/+/d801058048b2af3c21e32efe9137561ead01e5ed

[alito, 2017-06-02 04:08:59]

The CQ bit was checked by alito@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 04:09:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alito, 2017-06-02 04:14:10]

alito@chromium.org changed reviewers:
+ csharp@chromium.org, robertshield@chromium.org

[alito, 2017-06-02 04:14:11]

Robert, Chris, could you take a look at this when you get a chance? I'd like to
land this soonish if possible. Thanks!

/ali

PS you'll be happy to see that this CL is quite small and self-contained :)

[commit-bot: I haz the power, 2017-06-02 05:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 05:14:23]

Dry run: This issue passed the CQ dry run.

[csharp, 2017-06-02 18:18:27]

Overall LGTM, just one small suggestion

https://codereview.chromium.org/2918053003/diff/20001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc
(right):

https://codereview.chromium.org/2918053003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc:79:
settings_types_initialized_(0),
Worth moving the initialization of these values that don't take a parameter to
their definitions? (so probably moving from here to line 84)

[alito, 2017-06-02 18:54:26]

Thanks Chris. Robert?

https://codereview.chromium.org/2918053003/diff/20001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc
(right):

https://codereview.chromium.org/2918053003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc:79:
settings_types_initialized_(0),
On 2017/06/02 18:18:27, csharp wrote:
> Worth moving the initialization of these values that don't take a parameter to
> their definitions? (so probably moving from here to line 84)

Done.

[robertshield, 2017-06-02 21:31:24]

lgtm

[alito, 2017-06-03 20:31:58]

The CQ bit was checked by alito@chromium.org

[alito, 2017-06-03 20:31:59]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2918053003/#ps40001
(title: "Addressed Chris's comment")

[commit-bot: I haz the power, 2017-06-03 20:32:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 20:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 20:39:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alito, 2017-06-03 20:46:04]

alito@chromium.org changed reviewers:
+ sky@chromium.org

[alito, 2017-06-03 20:46:05]

Adding sky@ for OWNERS approval for:
  chrome/browser/ui/views/settings_reset_prompt_dialog_browsertest.cc

[sky, 2017-06-05 16:16:13]

LGTM

[alito, 2017-06-05 16:53:21]

The CQ bit was checked by alito@chromium.org

[commit-bot: I haz the power, 2017-06-05 16:53:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:55:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496681601206910,
"parent_rev": "f4731b44296ceb64fa017aeea52a6978ddb2c073", "commit_rev":
"d801058048b2af3c21e32efe9137561ead01e5ed"}

[commit-bot: I haz the power, 2017-06-05 17:56:01]

Description was changed from

==========
Settings reset prompt: Fetch default settings only when needed.

Instead of fetching the default settings when we create the
SettingsResetPromptModel object, which is some time after startup, we
now fetch settings only if the settings reset dialog needs to be shown
to the user.

BUG=727829
==========

to

==========
Settings reset prompt: Fetch default settings only when needed.

Instead of fetching the default settings when we create the
SettingsResetPromptModel object, which is some time after startup, we
now fetch settings only if the settings reset dialog needs to be shown
to the user.

BUG=727829

Review-Url: https://codereview.chromium.org/2918053003
Cr-Commit-Position: refs/heads/master@{#477019}
Committed:
https://chromium.googlesource.com/chromium/src/+/d801058048b2af3c21e32efe9137...
==========

[commit-bot: I haz the power, 2017-06-05 17:56:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d801058048b2af3c21e32efe9137...