linux and chromeos: Turn on -Wunused-const-variable.

linux and chromeos: Turn on -Wunused-const-variable.

BUG=307668
R=hans@chromium.org
TBR=oshima

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229578

[hans, 2013-10-18 21:44:59]

lgtm

https://codereview.chromium.org/29263007/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/29263007/diff/1/build/common.gypi#newcode3228
build/common.gypi:3228: '-Wno-unused-const-variable',
what's this for? CrOS & Android?

[Nico, 2013-10-18 21:51:09]

On Fri, Oct 18, 2013 at 2:44 PM, <hans@chromium.org> wrote:

> lgtm
>
>
>
https://codereview.chromium.**org/29263007/diff/1/build/**common.gypi<https:/...
> File build/common.gypi (right):
>
> https://codereview.chromium.**org/29263007/diff/1/build/**
>
common.gypi#newcode3228<https://codereview.chromium.org/29263007/diff/1/build/common.gypi#newcode3228>
> build/common.gypi:3228: '-Wno-unused-const-variable',
> what's this for? CrOS & Android?
>

Yupp.


>
>
https://codereview.chromium.**org/29263007/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-18 22:57:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/29263007/1

[Nico, 2013-10-18 23:35:17]

This grew slightly due to linux/aura. Please take another look.

[commit-bot: I haz the power, 2013-10-18 23:54:08]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[hans, 2013-10-18 23:58:38]

lgtm too

[commit-bot: I haz the power, 2013-10-18 23:59:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/29263007/90001

[Nico, 2013-10-19 01:18:42]

I figured since I have views already I should do chromeos too. Turns out that
this made this a bit larger again :-/

oshima: OWNERS for ash/ and chromeos/ please.

[commit-bot: I haz the power, 2013-10-19 01:42:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-19 02:14:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/29263007/320001

[commit-bot: I haz the power, 2013-10-19 03:08:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-19 05:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/29263007/500001

[commit-bot: I haz the power, 2013-10-19 10:36:39]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-19 16:04:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/29263007/500001

[Nico, 2013-10-19 16:21:06]

Committed patchset #4 manually as r229578.