Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chromeos/network/network_sms_handler.cc

Issue 29263007: linux and chromeos: Turn on -Wunused-const-variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/network/network_device_handler.cc ('k') | ui/app_list/views/app_list_item_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_sms_handler.h" 5 #include "chromeos/network/network_sms_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chromeos/dbus/dbus_thread_manager.h" 14 #include "chromeos/dbus/dbus_thread_manager.h"
15 #include "chromeos/dbus/shill_device_client.h" 15 #include "chromeos/dbus/shill_device_client.h"
16 #include "chromeos/dbus/shill_manager_client.h" 16 #include "chromeos/dbus/shill_manager_client.h"
17 #include "chromeos/dbus/gsm_sms_client.h" 17 #include "chromeos/dbus/gsm_sms_client.h"
18 #include "chromeos/dbus/modem_messaging_client.h" 18 #include "chromeos/dbus/modem_messaging_client.h"
19 #include "chromeos/dbus/sms_client.h" 19 #include "chromeos/dbus/sms_client.h"
20 #include "dbus/object_path.h" 20 #include "dbus/object_path.h"
21 #include "third_party/cros_system_api/dbus/service_constants.h" 21 #include "third_party/cros_system_api/dbus/service_constants.h"
22 22
23 namespace { 23 namespace {
24 24
25 // Not exposed/exported: 25 // Not exposed/exported:
26 const char kSmscKey[] = "smsc";
27 const char kValidityKey[] = "validity";
28 const char kClassKey[] = "class";
29 const char kIndexKey[] = "index"; 26 const char kIndexKey[] = "index";
30 27
31 // Keys from ModemManager1 28 // Keys from ModemManager1
32 const char kModemManager1NumberKey[] = "Number"; 29 const char kModemManager1NumberKey[] = "Number";
33 const char kModemManager1TextKey[] = "Text"; 30 const char kModemManager1TextKey[] = "Text";
34 const char kModemManager1TimestampKey[] = "Timestamp"; 31 const char kModemManager1TimestampKey[] = "Timestamp";
35 32
36 // Maximum number of messages stored for RequestUpdate(true). 33 // Maximum number of messages stored for RequestUpdate(true).
37 const size_t kMaxReceivedMessages = 100; 34 const size_t kMaxReceivedMessages = 100;
38 35
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 this, dbus_connection, object_path)); 479 this, dbus_connection, object_path));
483 } else { 480 } else {
484 device_handlers_.push_back( 481 device_handlers_.push_back(
485 new ModemManagerNetworkSmsDeviceHandler( 482 new ModemManagerNetworkSmsDeviceHandler(
486 this, dbus_connection, object_path)); 483 this, dbus_connection, object_path));
487 } 484 }
488 } 485 }
489 486
490 487
491 } // namespace chromeos 488 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/network_device_handler.cc ('k') | ui/app_list/views/app_list_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698