chrome/renderer/printing/print_web_view_helper_browsertest.cc - Issue 29263007: linux and chromeos: Turn on -Wunused-const-variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_browsertest.cc

Issue 29263007: linux and chromeos: Turn on -Wunused-const-variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_browsertest.cc b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

index f061bc3de088b7262eb4420df48082b0eb146940..7d8afecef92af9f2b8ff3149d7f81e547069cb39 100644

--- a/chrome/renderer/printing/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

@@ -31,6 +31,13 @@ namespace {

// A simple web page.

const char kHelloWorldHTML[] = "<body><p>Hello World!</p></body>";

+// A simple webpage with a button to print itself with.

+const char kPrintOnUserAction[] =

+ "<body>"

+ " <button id=\"print\" onclick=\"window.print();\">Hello World!</button>"

+ "</body>";

+#if !defined(OS_CHROMEOS)

// HTML with 3 pages.

const char kMultipageHTML[] =

"<html><head><style>"

@@ -66,12 +73,6 @@ const char kHTMLWithLandscapePageCss[] =

"<body>Lorem Ipsum:"

"</body></html>";

-// A simple webpage with a button to print itself with.

-const char kPrintOnUserAction[] =

- "<body>"

- " <button id=\"print\" onclick=\"window.print();\">Hello World!</button>"

- "</body>";

// A longer web page.

const char kLongPageHTML[] =

"<body><img src=\"\" width=10 height=10000 /></body>";

@@ -79,6 +80,7 @@ const char kLongPageHTML[] =

// A web page to simulate the print preview page.

const char kPrintPreviewHTML[] =

"<body><p id=\"pdf-viewer\">Hello World!</p></body>";

+#endif // !defined(OS_CHROMEOS)

void CreatePrintSettingsDictionary(base::DictionaryValue* dict) {

dict->SetBoolean(kSettingLandscape, false);